r23706 - gnucash/trunk/src/register/ledger-core - Bug 721791 - Segmentation fault when correcting invalid date

[John Ralls]

On Jan 18, 2014, at 2:47 PM, Christian Stimming <christian at cstimming.de> wrote:

> Am Samstag, 18. Januar 2014, 16:50:22 schrieb John Ralls:
>> Author: jralls
>> Date: 2014-01-18 16:50:21 -0500 (Sat, 18 Jan 2014)
>> New Revision: 23706
>> Trac: http://svn.gnucash.org/trac/changeset/23706
>> 
>> Modified:
>>   gnucash/trunk/src/register/ledger-core/split-register-model.c
>> Log:
>> Bug 721791 - Segmentation fault when correcting invalid date
>> 
>> And greatly simplify gnc_split_register_get_date_help by just getting a
>> GDate and running g_date_strftime on it instead of messing around with
>> Timespecs and g_localtime_r (twice!) and all of that just to make a stupid
>> string.
> 
> Thanks for fixing the bug!
> 
> Note that the functions for using the GDate are still relatively new in 
> gnucash. That's why in most cases they are not (yet) being used, even though 
> they are more suitable and less error-prone and better altogether :-)

And one of the GLib dependencies that we're getting rid of. ;-) 

No worries, though: Boost::gregorian [1] has more-or-less the same functionality with I hope less work.

Regards,
John Ralls

[1] http://www.boost.org/doc/libs/1_55_0/doc/html/date_time/gregorian.html#date_time.gregorian.date_class