gnucash master: Multiple changes pushed

[Sumit Bhardwaj]

Hi John,

That works - to an extent. gcc fails and the current configuration is:
 -Werror -Wdeclaration-after-statement -Wno-pointer-sign -D_FORTIFY_SOURCE=2

Configure doesn't fail, but that the flags are far fewer than earlier. Is
this, what we want to go ahead with?

If anyone wants to look at the changes in
macros/m4_ax_check_compile_flag.m4 and configure.ac, I have pushed the
changes to master  repo on my github (https://github.com/bhardwajs/gnucash).

Cheers,
Sumit

P.S. - Apologies for a two-month hiatus. Work drained a lot of time and
energy. Should be better now. :)

On Sun, Jul 6, 2014 at 1:05 AM, John Ralls <jralls at ceridwen.us> wrote:

>
> On Jul 5, 2014, at 11:34 PM, Sumit Bhardwaj <bhardwajs at gmail.com> wrote:
>
> > Sure, John. Here you go. Interestingly, I didn't find conftest.c in the
> directory tree.
> >
> > 'tree | grep conftest.c' gave no output.
> >
> > Thanks,
> > Sumit
> >
> > configure:25408: checking whether C++ compiler accepts
> -Wno-deprecated-register
> > configure:25427: g++ -c -g -O2 -std=gnu++11 -Werror
> -Wno-deprecated-register  conftest.cpp >&5
> > configure:25427: $? = 0
> > configure:25435: result: yes
> > configure:25449: checking whether C compiler accepts
> -Wno-non-literal-null-conversion
> > configure:25468: gcc -c -g -O2 -Werror -Wno-non-literal-null-conversion
>  conftest.c >&5
> > configure:25468: $? = 0
> > configure:25476: result: yes
> > configure:25484: checking what extra warning flags to pass to the C
> compiler
> > configure:25547: gcc -c  -Wall -Wunused -Wmissing-prototypes
> -Wmissing-declarations  -Wno-non-literal-null-conversion -Wno-unused -g -O2
> -Werror -D_FORTIFY_SOURCE=2  conftest.c >&5
> > configure:25547: $? = 0
> > configure:25560: result:  -Werror -Wdeclaration-after-statement
> -Wno-pointer-sign -D_FORTIFY_SOURCE=2
> > configure:25697: checking that generated files are newer than configure
> > configure:25703: result: done
> > configure:25835: creating ./config.status
>
> Interesting. I suspect that AX_CHECK_COMPILE_FLAG isn't getting cc1
> invoked, only cpp, because it passes in an effectively empty program.
>
> Try editing macros/m4_ax_check_compile_flag.m4 so that
>   AC_COMPILE_IFELSE([m4_default([$5],[AC_LANG_PROGRAM()])],
> becomes
>   AC_COMPILE_IFELSE([m4_default([$5],[AC_LANG_PROGRAM(
>         [[const char hw[] = "Hello, World\n";]],
>         [[fputs (hw, stdout);]])]))])],
>
> and see if that will get it to fail in configure. You'll need to re-run
> autogen.sh to pull the modified macro into configure.
>
> Regards,
> John Ralls
>
>
>