Boost Version Required ?

[John Ralls]

On Oct 9, 2014, at 7:10 AM, John Ralls <jralls at ceridwen.us> wrote:

> 
> On Oct 9, 2014, at 6:23 AM, Geert Janssens <geert.gnucash at kobaltwit.be> wrote:
> 
>> On Thursday 09 October 2014 09:12:15 Aaron Laws wrote:
>>> On Thu, Oct 9, 2014 at 8:11 AM, Geert Janssens
>>> <geert.gnucash at kobaltwit.be>
>>> wrote:
>>>> Oops.
>>>> 
>>>> "Officially" we target 1.48, but apparently some more recent
>>>> features
>>>> got used in the last commits.
>>>> 
>>>> John, Aaron: how do we deal with this ?
>>> 
>>> Good question. Something like the full story can be found at
>>> https://bugzilla.gnome.org/show_bug.cgi?id=736687 . In short, that
>>> include was added because of a bug identified in jralls's build
>>> environment: his boost/variant.hpp didn't include the file, so there
>>> was a compilation issue which was fixed by including it ourselves. My
>>> version built properly without the include, and we're using the same
>>> boost version: 1.56.0. Since we target 1.48, perhaps I should get
>>> that version of boost to make sure to avoid this type of thing. Of
>>> course, boost 1.56.0 *is* freely available :-).
>> 
>> Freely available, yes. In source code. Prepackaged in linux 
>> distributions, no. We are usually conservative in our version 
>> requirements to keep it relatively simple for others to build gnucash 
>> without also having to build its dependencies.
>> 
>> Current master will not ship for some time to come. By then boost 1.56 
>> is probably pretty common. However requiring it now already however will 
>> make it more difficult for others to jump in.
>> 
> 
> Since that include is a workaround for a boost bug in 1.56 -- the function is used in boost/variant/variant.hpp but the header isn't included -- we can guard the include in kvp-value.hpp with BOOST_VERSION, which is found in boost/version.h.
> 

I’ve pushed this.

Regards,
John Ralls