Master: make distcheck failure

[Geert Janssens]

On Friday 16 January 2015 15:25:56 Geert Janssens wrote:
> Hi,
> 
> Tried to run make distcheck today on current master and got this error
> output:
> 
> make[3]: Entering directory
> `/kobaltnet/janssege/Development/Builds/gnucash-f20-
> master/src/libqof'
>  (cd qof && make  top_distdir=../../../gnucash-2.6.99
> distdir=../../../gnucash-2.6.99/src/libqof/qof \
>      am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
> distdir) make[4]: Entering directory
> `/kobaltnet/janssege/Development/Builds/gnucash-f20-
> master/src/libqof/qof'
> make[4]: *** No rule to make target `qofmath128.cpp', needed by
> `distdir'.  Stop.
> 
> I find that qofmath128.cpp is in the EXTRA_DIST section of the
> makefile, but I don't see this file anywhere in the source tree.
> 
> Is this a leftover from earlier experiments ?
> 
> Geert
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

I continued by temporarily removing this EXTRA_DIST part. Reran make distcheck and now I'm 
running into:
make[5]: Entering directory `/kobaltnet/janssege/Development/Builds/gnucash-f20-
master/src/libqof/qof/test'
make[5]: *** No rule to make target `/src/gtest_main.cc', needed by `distdir'.  Stop.

It appears to come from the rule
if WITH_GOOGLE_TEST
test_gnc_int128_SOURCES = \
        $(top_srcdir)/${MODULEPATH}/gnc-int128.cpp \
        ${GTEST_ROOT}/src/gtest_main.cc \
        gtest-gnc-int128.cpp

...

WITH_GOOGLE_TEST is not set on my system. It appears this is conditional is ignored for this 
definition, because this is what I find in Makefile.in:
@WITH_GOOGLE_TEST_TRUE at am__EXEEXT_1 = test-gnc-int128$(EXEEXT) \
@WITH_GOOGLE_TEST_TRUE@	test_kvp_value$(EXEEXT)
am__test_gnc_int128_SOURCES_DIST =  \
	$(top_srcdir)/${MODULEPATH}/gnc-int128.cpp \
	${GTEST_ROOT}/src/gtest_main.cc gtest-gnc-int128.cpp

So this definition is evaluated regardless of the value of WITH_GOOGLE_TEST.

Why is beyond me...

Geert