GnuCash page Development has been changed by Jralls
jralls at ceridwen.us
Wed Jul 6 09:54:32 EDT 2016
> On Jul 6, 2016, at 12:31 AM, Chris Good <chris.good at ozemail.com.au> wrote:
>> -----Original Message-----
>> From: John Ralls [mailto:jralls at ceridwen.us]
>> Sent: Wednesday, 6 July 2016 1:06 PM
>> To: Chris Good <chris.good at ozemail.com.au>
>> Cc: gnucash-devel <gnucash-devel at gnucash.org>
>> Subject: Re: GnuCash page Development has been changed by Jralls
>>> On Jul 5, 2016, at 4:42 PM, Chris Good <chris.good at ozemail.com.au>
>>> Hi John,
>>> Re your last change to http://wiki.gnucash.org/wiki/Development :
>>> Github pull requests: This is the preferred method if the change is
>>> non-trivial and there isn't already a bug report on the matter.
>>> The above implies to me that if there IS already a bug report, you'd
>>> prefer a patch. Is that correct?
>> I'm trying to make contributing palatable to all comers.
>> In reality it depends on how complex the patch is. If it's a big change
>> rather review it on Github than in plain text on a bug. OTOH if it's a
> simple fix
>> it makes more sense and is less work to just do a format-patch and upload
>> to BZ, especially if the user doesn't have a github account already. I
>> want to make it seem like that sort of patch is a second-class
>> and I don't want to make that paragraph so laden with if-this-then-that
> that it
>> turns off casual bug-fixers.
>> Can you come up with better wording?
>> John Ralls
> Hi John,
> How about:
> Github pull requests: This is the preferred method if the change is
> non-trivial. Patches are also acceptable.
> Let me know if this is OK and I'll do it. I'm very happy for you to spend
> your time more productively.
> Congratulations on 2.6.13 BTW. I haven't seen any reports of problems -
> Thanks to all developers :-)
That would be redundant. That line is 1 in a numbered list, and 2 is "Attach a patch to a bug report."
I've reworded it to make the bugzilla statement a bullet under the item and changed it from "and there isn't..." to "If there is already a bug report on the matter be sure to include a link to the bug in the pull request and comment on the bug with a link to the pull request."
I think that conveys exactly what we want.
More information about the gnucash-devel