Transaction Posted Time

Geert Janssens geert.gnucash at kobaltwit.be
Tue Jun 21 15:10:12 EDT 2016


On Monday 20 June 2016 13:43:18 John Ralls wrote:
> > On Jun 20, 2016, at 12:36 PM, Geert Janssens
> > <geert.gnucash at kobaltwit.be> wrote:> 
> > On Monday 20 June 2016 12:14:24 John Ralls wrote:
> > > > Hi John,
> > > > 
> > > > In addition to the time stamp use cases Christian already
> > > > mentioned,
> > > > I believe the time stamp is also relevant for sorting entries on
> > > > an
> > > > invoice/bill ledger. This was implemented as a hack by Christian
> > > > IIRC such that to move an entry up or down the list on the same
> > > > day, internally the post dates of the two entries would be
> > > > swapped.
> > > > As the post times currently all differ, this would effectively
> > > > alter the sorting order. If all post times will be normalized
> > > > this
> > > > hack will no longer work. That's one other case to keep in mind
> > > > when dropping post times.
> > > > 
> > > > Other than that I'm fine with making the time change for the
> > > > next
> > > > release.
> > > 
> > > Geert,
> > > 
> > > Where is that code?
> > > 
> > > Regards,
> > > John Ralls
> > 
> > https://github.com/Gnucash/gnucash/blob/master/src/business/business
> > -ledger/gncEntryLedger.c#L975
> > 
> > Which is called from gnc_invoice_window_entryUpCB and
> > gnc_invoice_window_entryUpCB in
> > https://github.com/Gnucash/gnucash/blob/master/src/business/busines
> > s-gnome/dialog-invoice.c
> > 
> > These in turn get called by callbacks for gui buttons
> > (gnc_plugin_page_invoice_cmd_entryUp/Down). These callbacks can be
> > found in
> > https://github.com/Gnucash/gnucash/blob/master/src/business/busines
> > s-gnome/gnc-plugin-page-invoice.c
> Geert,
> 
> No problem then. That adjusts a GncEntry's date_entered, not a
> Transaction's date_posted.
> 
> Regards,
> John Ralls

Good!

That will only make it a point of attention whenever we decide to drop timestamps 
altogether from GnuCash.

Regards,

Geert


More information about the gnucash-devel mailing list