Master on Windows 10

John Ralls jralls at ceridwen.us
Thu May 5 07:27:04 EDT 2016


> On May 5, 2016, at 6:16 AM, Robert Fewell <14ubobit at gmail.com> wrote:
> 
> I have looked into these errors and have found the problem, the windows version of strftime does not support all the format flags on Linux and so the errors.
> 
> There are two places I see this error..
> The first is from function gnc_ctime at line 234 of gnc-date.cpp, the format string uses a %e for the day of the month with a leading space. This I think can be changed to %d, a leading zero if required, as searching for that function shows it is only used in PINFO statements.
> 
> The second is generate_statusbar_lastmodified_message at line 1654 of gnc-main-window.cpp, again the format string uses %e so could be replaced with %d but also uses %P for a lower case am/pm but this could be changed to %p for upper case.
> 
> I looked at these references...
> http://www.boost.org/doc/libs/1_60_0/doc/html/date_time/date_time_io.html#date_time.format_flags <http://www.boost.org/doc/libs/1_60_0/doc/html/date_time/date_time_io.html#date_time.format_flags>
> https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx <https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx>

Robert,

Thanks for troubleshooting it. Yes, those changes are quite acceptable. Do you want to make a PR or shall I just change it?

Regards,
John Ralls



More information about the gnucash-devel mailing list