Re: github pull requests

Derek Atkins derek at ihtfp.com
Tue May 31 08:11:09 EDT 2016


Even as a pull request!  :-)

-derek

Sent on my mobile. Please forgive any typos.

----- Reply message -----
From: "Geert Janssens" <geert.gnucash at kobaltwit.be>
To: <gnucash-devel at gnucash.org>
Cc: "Chris Good" <chris.good at ozemail.com.au>
Subject: github pull requests
Date: Tue, May 31, 2016 1:12 PM

Hi Chris,

Good catch. We do accept pull requests indeed and I believe we even prefer them for large 
change sets now.

I have made a minimal change to the README. It could use a better wording than mine so feel 
free to express it more clearly.

Thanks

Geert

On Tuesday 31 May 2016 19:07:43 Chris Good wrote:
> Hi,
> 
> 
> 
> Just pointing out an inconsistency if you think it worth fixing.
> 
> I believe the following from the github README file is out of date.
> 
> 
> 
> ##############################
> 
> Getting Source with Git
> 
> ------------------------------
> 
> 
> 
> We maintain a mirror of our master repository on Github. You can
> 
> browse the code at https://github.com/Gnucash/gnucash. Clone URIs are
> 
> on that page, or if you have a Github account you can fork it
> 
> there. Note, however, that we do *not* accept Github pull requests:
> 
> All patches should be submitted via Bugzilla, see below.
> 
> 
> 
> 
> 
> Whereas http://wiki.gnucash.org/wiki/Git#Pull_Requests says
> 
> 
> 
> 
> Pull Requests[edit
> <http://wiki.gnucash.org/wiki/index.php?title=Git&action=edit&section=
> 9> ]
> 
> 
> If you prefer, you can use a GitHub Pull Request instead of attaching
> a patch to a bug.
> 
> Regards,
> 
> Chris Good

_______________________________________________
gnucash-devel mailing list
gnucash-devel at gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


More information about the gnucash-devel mailing list