[Gnucash/gnucash] Guid header (#109)
dartme18 at gmail.com
Tue Oct 25 15:03:31 EDT 2016
I created a docker container that may immitate the build situation on
travis. It is based on ubuntu 14.04 and has the same gcc version:
gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
It does reproduce the problem I was having with pull request 109, but it
doesn't complete the build when that problem is solved. Several tests pass,
but there is some problem with po files; here is the build output at the
if [ -r missing -o -r notexist ]; then \
exit 1; \
make: *** [check] Error 1
make: Leaving directory `/repos/gnucash/build/po'
make: *** [check-recursive] Error 1
You can use the image here: https://hub.docker.com/r/lmat/gnucash-build/.
The description talks about how to use it, but let me know if you have any
questions. It is my first docker image.
On Tue, Oct 25, 2016 at 12:21 PM, John Ralls <notifications at github.com>
> The problem Travis found is that brace-initializer-list initialization
> <http://en.cppreference.com/w/cpp/language/list_initialization> is
> handled differently in C++11 and C++14. For this cycle we need to stick to
> C++11, so you need to be careful about using initializer lists. Gcc should
> warn about that if you've got -std=c++11 set.
> While you're at it, could you elaborate the last commit message to say
> that you've replaced inheritance from boost::guid::guid with composition?
> Otherwise very nice. Composition is clearly a better choice here.
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Gnucash/gnucash/pull/109#issuecomment-256084938>, or mute
> the thread
More information about the gnucash-devel