Source directory restructuring complete

Fri Aug 18 03:30:50 EDT 2017

On vrijdag 18 augustus 2017 07:07:02 CEST Sumit Bhardwaj wrote:
> Hi Geert,
> 
> Coming back to this thread, I found some time today to see if I can build
> using autotools. After pulling the latest master, "make" and "make check"
> both worked. So, I am good building with autotools.
> 
Good. Just to be clear - does this imply you were attempting a cmake build 
before when you reported your errors ?

> For now, I will try to work on CSV importer if and when I find time - it's
> going to be a challenge with a vacation coming soon.
> 
> Thanks,
> Sumit
> 
Very well. Do report your progress regularly though to avoid double work.

Enjoy your holidays!

Geert

> On Tue, Aug 15, 2017 at 7:54 AM, Geert Janssens <geert.gnucash at kobaltwit.be>
> wrote:
> > Hmm,
> > 
> > And I meant to add, can you post the contents of the test logs for the
> > failing
> > tests ?
> > 
> > You will find them in ../build_gnucash/libgnucash/engine/test/
> > The logs are named after the tests so you'll be looking for
> > test-test-extras.log
> > test-account.log
> > test-split.log
> > 
> > Geert
> > 
> > On dinsdag 15 augustus 2017 16:48:16 CEST Geert Janssens wrote:
> > > Hi Sumit,
> > > 
> > > Thanks for running the tests and reporting your issues. These are not
> > 
> > known
> > 
> > > problems. I have run both cmake and autotools builds before submitting
> > > my
> > > work and for both build systems I had all the tests succeeding. The
> > > autotools build also completes fine on travis. So there is something
> > > different in your environment. That can be either because you are on
> > 
> > Fedora
> > 
> > > 26 (I'm on 25 still) which comes with newer versions of several tools,
> > > or
> > > an unclean build environment.
> > > 
> > > Last week Aaron Laws reported having issues on Arch linux due to it
> > 
> > having
> > 
> > > both guile 2.0 and 2.2. Perhaps that's biting you as well ?
> > > 
> > > Geert
> > > 
> > > On dinsdag 15 augustus 2017 08:22:04 CEST Sumit Bhardwaj wrote:
> > > > Hi Geert,
> > > > 
> > > > Pulled master and tried to build using autotoosls. As per your
> > 
> > suggestion,
> > 
> > > > I built in ../build_gnucash which is parallel to the top-level gnucash
> > > > directory.
> > > > 
> > > > make succeeded.
> > > > make install succeeded as well.
> > > > make check failed with 3 tests - error message below. Is this a known
> > > > problem?
> > > > 
> > > > I haven't tried building using cmake. My system configuration is also
> > > > below
> > > > (Fedora 26).
> > > > 
> > > > Thanks,
> > > > Sumit
> > > > 
> > > > System config:
> > > > ----------------------
> > > > 
> > > >  gnucash version ...... : 2.6.99
> > > >  Build for host ....... : x86_64-pc-linux-gnu
> > > >  Optional components... :  dbi
> > > >  Extra Warnings ....... :  -Werror -Wdeclaration-after-statement
> > > > 
> > > > -Wno-pointer-sign -D_FORTIFY_SOURCE=2
> > > > 
> > > >  CPPFLAGS ............. :
> > > >  CFLAGS ............... : -g -O2 -std=gnu11
> > > >  CXXFLAGS ............. : -g -O2
> > > >  LDFLAGS .............. :
> > > >  prefix................ : /usr/local
> > > > 
> > > > Test error
> > > > ...
> > > > mkdir -p  gnucash/engine/test
> > > > ( cd gnucash/engine/test; for A in test-extras.scm ; do ln -s -f
> > > > /home/bhardwajs/ac/devel/build_gnucash/../gnucash/libgnucash/engine/t
> > > > est/$A . ; done )
> > > > touch .scm-links
> > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";' >
> > > > test-test-extras
> > > > echo 'export GNC_UNINSTALLED=yes;' >> test-test-extras
> > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > ../../../../gnucash/libgnucash/engine/test/test-test-extras.scm -c "
> > > > (exit (run-test))"' >> test-test-extras
> > > > chmod a+x test-test-extras
> > > > FAIL: test-test-extras
> > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";' >
> > > > test-account
> > > > echo 'export GNC_UNINSTALLED=yes;' >> test-account
> > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > ../../../../gnucash/libgnucash/engine/test/test-account.scm -c "(exi
> > > > t (run-test))"' >> test-account
> > > > chmod a+x test-account
> > > > FAIL: test-account
> > > > echo 'export GNC_BUILDDIR="/home/bhardwajs/ac/devel/build_gnucash";' >
> > > > test-split
> > > > echo 'export GNC_UNINSTALLED=yes;' >> test-split
> > > > echo '/home/bhardwajs/ac/devel/build_gnucash/gnc-guile --debug -l
> > > > ../../../../gnucash/libgnucash/engine/test/test-split.scm -c "(exit
> > > > (run-test))"' >> test-split
> > > > chmod a+x test-split
> > > > FAIL: test-split
> > 
> > ============================================================
> > ================
> > 
> > > > Testsuite summary for GnuCash 2.6.99
> > 
> > ============================================================
> > ================
> > 
> > > > ...
> > > > 
> > > > On Mon, Aug 14, 2017 at 9:57 AM, Geert Janssens
> > > > <geert.gnucash at kobaltwit.be>>
> > > > 
> > > > wrote:
> > > > > Hi,
> > > > > 
> > > > > I have just pushed my directory restructuring branch to master as I
> > > > > announced
> > > > > last week.
> > > > > 
> > > > > IMPORTANT: You should wipe out your existing build/install directory
> > > > > after
> > > > > pulling this new master. And if you are building in the source tree
> > > > > (which
> > > > > we
> > > > > don't advise) instead of having a separate build directory, be sure
> > 
> > to
> > 
> > > > > run
> > > > > "make distclean" there *BEFORE* pulling this new master.
> > > > > 
> > > > > Then proceed as usual, that is run
> > > > > autogen.sh/configure-with-options/make
> > > > > for
> > > > > an autotools
> > > > > based build or cmake-with-options/[make/ninja(-build)] for a cmake
> > 
> > based
> > 
> > > > > build.
> > > > > 
> > > > > The new directory structure is roughly as follows:
> > > > > 
> > > > > * data
> > > > > Non-code items that get installed (like account charts, check
> > 
> > formats,
> > 
> > > > > pixmaps)
> > > > > * libgnucash
> > > > > The core libraries which define our internal data structures and
> > 
> > code to
> > 
> > > > > handle them. This holds the core-utils, gnc-module, engine
> > > > > (including
> > > > > qof),
> > > > > app-utils and a few smaller ones
> > > > > * gnucash
> > > > > The code for the gui application built on top of libgnucash. Here
> > 
> > you'll
> > 
> > > > > find
> > > > > the directories gnome, gnome-utils, report, html, import-export,...
> > > > > * bindings
> > > > > Currently only the python bindings are here, in the future the guile
> > > > > bindings
> > > > > should be migrated here as well.
> > > > > * common
> > > > > Low level support code, mostly for debugging and testing (debug,
> > 
> > test-
> > 
> > > > > core,...)
> > > > > 
> > > > > In the restructuring, the cutecash project has been removed together
> > > > > with
> > > > > the
> > > > > gtkmm support library.
> > > > > 
> > > > > A few other directories have been eliminated and their content moved
> > 
> > to
> > 
> > > > > other
> > > > > locations:
> > > > > - src/bin -> gnucash (no more separate subdirectory)
> > > > > - src/optional: the python-bindings subdirectory has been moved to
> > > > > bindings,
> > > > > the only other subdir was gtkmm which has been dropped
> > > > > - src/plugins: the two real "plugins' in there were in fact import
> > > > > modules, so
> > > > > they have been moved to import-export. The example subdirectory
> > 
> > (which
> > 
> > > > > is
> > > > > never built) is now a subdirectory of libgnucash/gnc-module
> > > > > 
> > > > > Please report any problems you may experience with this new work.
> > > > > 
> > > > > Regards,
> > > > > 
> > > > > Geert
> > > > > _______________________________________________
> > > > > gnucash-devel mailing list
> > > > > gnucash-devel at gnucash.org
> > > > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> > > 
> > > _______________________________________________
> > > gnucash-devel mailing list
> > > gnucash-devel at gnucash.org
> > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> > 
> > _______________________________________________
> > gnucash-devel mailing list
> > gnucash-devel at gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel