build after last update

[Geert Janssens]

I had the same issue here and I've just pushed a fix.

It turns out our cmake config files use a different check for packages based 
on the version of cmake itself. I presume there was a bug in cmake 3.1-3.4 
that made this necessary.

The default cmake fails on the "OPTIONAL" modifier. where the checks in the 
alternative path seem to ignore it instead. I have removed the OPTIONAL 
specifier and this works fine with cmake 3.8 (on Fedora 25). I don't have a 
system handy to test whether it works with 3.1-3.4 as well.

Can you test this John ?

Geert

On zondag 9 juli 2017 04:50:54 CEST John Ralls wrote:
> > On Jul 8, 2017, at 5:38 PM, Alex Aycinena <alex.aycinena at gmail.com> wrote:
> > 
> > After the last update, my Fedora 25 system won't build with the following
> > output:
> > 
> > [gnucash-dev at HPdv5Fedora gnucash-working-build]$ make
> > -- Checking for modules 'OPTIONAL;webkit2gtk-4.0'
> > --   No package 'OPTIONAL' found
> > --   No package 'webkit2gtk-4.0' found
> > -- Checking for module 'webkit2gtk-3.0'
> > --   No package 'webkit2gtk-3.0' found
> > 
> > CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:416 (message):
> >  A required package was not found
> > 
> > I installed webkitgtk3-devel but it didn't solve the problem and I
> > couldn't
> > find any package for webkit2gtk-4.0' or webkit2gtk-3.0. Can anyone help me
> > out. I believe Geert develops on Fedora 25 as well.
> 
> Alex,
> 
> What webkit*.pc do you have?
> 
> There’s apparently a webkitgtk4-devel that’s supposed to provide
> webkit2gtk-4.0.pc, but webkitgtk3-devel is supposed to provide
> webkit2gtk-3.0.pc.
> 
> Regards,
> John Ralls
> 
> 
> 
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel