Compile error on clean build on Fedora 26

[John Ralls]

> On Jul 20, 2017, at 3:17 PM, Alex Aycinena <alex.aycinena at gmail.com> wrote:
> 
> On a new clean clone on a Fedora 26 VM, with the following configure:
> 
> ../gnucash-clean/configure
> --srcdir=/home/gnucash-dev/gitcheckouts/gnucash-clean
> --prefix=/opt/gnucash-git/gnucash-clean
> 
> I get the following error on make:
> 
> In file included from
> /home/gnucash-dev/gitcheckouts/gnucash-clean/src/libqof/qof/guid.cpp:25:0:
> /home/gnucash-dev/gitcheckouts/gnucash-clean/src/libqof/qof/guid.hpp:52:51:
> error: dynamic exception specifications are deprecated in C++11
> [-Werror=deprecated]
>     static GUID from_string (std::string const &) throw
> (guid_syntax_exception);
>                                                   ^~~~~
> /home/gnucash-dev/gitcheckouts/gnucash-clean/src/libqof/qof/guid.cpp:346:45:
> error: dynamic exception specifications are deprecated in C++11
> [-Werror=deprecated]
> GUID::from_string (std::string const & str) throw (guid_syntax_exception)
>                                             ^~~~~
> cc1plus: error: unrecognized command line option ‘-Wno-deprecated-register’
> [-Werror]
> cc1plus: all warnings being treated as errors
> make[5]: *** [Makefile:757: guid.lo] Error 1
> make[5]: Leaving directory
> '/home/gnucash-dev/gitcheckouts/gnucash-clean-build/src/libqof/qof'
> 
> Builds OK on Fedora 25 so osomething must have changed between the two.

Yeah, gcc v7 has a lot more warnings about obsolete behavior. The committee decided that two C++99 features, throw specs and auto_ptr, were irretrievably bad ideas so it's kind of surprising that compilers haven't been complaining about them for longer.

Grep found only that one, and I pushed a commit removing it. If you find more by all means remove them.

Regards,
John Ralls