gnucash maint: Multiple changes pushed

Geert Janssens geert.gnucash at kobaltwit.be
Thu Mar 23 06:49:08 EDT 2017


On woensdag 22 maart 2017 22:05:25 CET Geert Janssens wrote:
> commit 9f3ad5510427eb69c857814de15e1c1be0727d2d
> Author: Jesse Olmer <jesse at wickedgoodtimes.com>
> Date:   Sat Feb 13 21:59:05 2016 -0800
> 
>     Bug 739571 - Matching imported transactions doesn't indicate previously
> matched entries
> 
>     Track pending matches from the current import and display this
> information in the match picker.
> 

This commit (which I pushed myself) breaks travis because its unit test uses 
g_assert_true and friends.

A quick lookup shows the maint branch of gnucash is still running travis tests 
on Ubuntu 12.04 (Precise), which ships with glib-2.0 2.32 while g_assert_true 
was introduced in glib-2.0 2.38.

I'm in two minds about how to proceed.
- I could revert the patch and rework it for master only. This will delay its 
formal release with a few months.
- I could backport my patches that set the minimum required glib-2.0 version 
to 2.40 and adjust the travis environment to trusty (14.04) like master.

The fundamental question here is do we still want to support Ubuntu 12.04 ? It 
will be EOL by the end of next month so I don't know whether it's still worth 
spending effort for ?

What you others think ?

Geert


More information about the gnucash-devel mailing list