Bug#876306: gnucash FTBFS: object class 'Transaction' has no property named 'bogus'

[John Ralls]

No, no use case in mind. I think I wrote those tests in a somewhat robotic mode, trying to ensure complete test coverage for eventual refactoring of the GObject code in the various engine modules. We’ve since decided to drop GObject altogether and rewrite the classes in C++, so even if there was a reason to test GObject behavior there won’t be one for long.

By all means delete the test.

Regards,
John Ralls


> On Oct 3, 2017, at 1:47 PM, Geert Janssens <geert.gnucash at kobaltwit.be> wrote:
> 
> Hi,
> 
> I tend to agree with you and I have a patch waiting to be committed to solve 
> this. Before I commit it though I would like to hear from John if he had a 
> particular use case in mind when he chose to add this test.
> 
> Geert
> 
> On woensdag 27 september 2017 09:44:29 CEST Micha Lenk wrote:
>> Dear Gnucash developers,
>> 
>> The following bug has been reported in the Debian bug tracker as
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876306
>> 
>> I agree that Gnucash tests shouldn't test the behavior of GObject.
>> Please consider to drop this test.
>> 
>> Best regards,
>> Micha
>> 
>> 
>> ----- Forwarded message from Steve Langasek <steve.langasek at canonical.com>
>> -----
>> 
>> Date: Wed, 20 Sep 2017 12:12:16 -0700
>> From: Steve Langasek <steve.langasek at canonical.com>
>> To: submit at bugs.debian.org
>> Subject: Bug#876306: gnucash FTBFS: object class 'Transaction' has no
>> property named 'bogus'
>> 
>> Package: gnucash
>> Version: 1:2.6.17-1
>> Severity: serious
>> Tags: patch
>> User: ubuntu-devel at lists.ubuntu.com
>> Usertags: origin-ubuntu artful ubuntu-patch
>> 
>> Hi Dmitry,
>> 
>> The gnucash package has been failing to build in Ubuntu with a test failure,
>> and I have reproduced this failure in Debian unstable:
>> 
>>  /engine/Transaction/xaccTransScrubGainsDate_gains_dirty:             **
>> ERROR:utest-Transaction.c:452:test_gnc_transaction_set_get_property:
>> assertion failed (check1->hits == 1): (0 == 1) <INFO> (gnc.engine)
>> [xaccSplitEqualCheckBal] balances differ: 100000/1000 vs 200000/1000 <FATAL
>> WARNING> (GLib-GObject) g_object_set_is_valid_property: object class
>> 'Transaction' has no property named 'bogus' <FATAL WARNING> (GLib-GObject)
>> g_object_set_is_valid_property: object class 'Transaction' has no property
>> named 'bogus' OK
>>  /engine/Transaction/gnc transaction set/get property:                FAIL
>> GTester: last random seed: R02Sa8a1794f6622116b0a513984cbbbcc0f
>> Makefile:1926: recipe for target 'test-nonrecursive' failed
>> make[7]: *** [test-nonrecursive] Terminated
>> 
>>  https://launchpad.net/ubuntu/+source/gnucash/1:2.6.17-1/+build/13058180
>> 
>> This looks like a brittle test that has broken as a result of implementation
>> details in gobject; I don't see any reason why the gnucash test suite
>> should be testing the specific text of the error message returned by
>> gobject when performing a disallowed operation.  The gnucash implementation
>> never relies on the contents of this error string anywhere else, and it's
>> not the business of the gnucash testsuite to be testing the behavior of
>> gobject instead of its own.
>> 
>> So I think this particular test (or this aspect of the test) should be
>> dropped.  But in the meantime, here is a patch that fixes the test failure
>> on Debian and Ubuntu.
>> 
>> Thanks,
> 
> 
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel