gnucash unstable: Don't build design docs on Windows.

[Geert Janssens]

Op zondag 22 oktober 2017 20:52:00 CEST schreef John Ralls:
> Updated	 via  https://github.com/Gnucash/gnucash/commit/70a37a24 (commit)
> 	from  https://github.com/Gnucash/gnucash/commit/7b44e280 (commit)
> 
> 
> 
> commit 70a37a24ae013023a96e63625c30a0432ebcd136
> Author: John Ralls <jralls at ceridwen.us>
> Date:   Sun Oct 22 11:51:26 2017 -0700
> 
>     Don't build design docs on Windows.
> 
>     To avoid requiring texinfo.
> 
> diff --git a/libgnucash/doc/CMakeLists.txt b/libgnucash/doc/CMakeLists.txt
> index 19ffc16..8f6e5a1 100644
> --- a/libgnucash/doc/CMakeLists.txt
> +++ b/libgnucash/doc/CMakeLists.txt
> @@ -1,4 +1,6 @@
> -ADD_SUBDIRECTORY(design)
> +if (!WIN32)
> +  ADD_SUBDIRECTORY(design)
> +endif()
>  ADD_SUBDIRECTORY(xml)
> 
>  SET(doc_FILES
> 
> 
> 
> Summary of changes:
>  libgnucash/doc/CMakeLists.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> _______________________________________________
> gnucash-changes mailing list
> gnucash-changes at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-changes

I started seeing cmake warnings and make dist failures the last couple of 
days. I bisected it back to this commit. Apparently cmake 3.9.1 doesn't like 
it if you only conditionally add subdirectories.

Here's the warning cmake produces (on Fedora 25 & 26):
----
CMake Warning (dev):
  Policy CMP0058 is not set: Ninja requires custom command byproducts to be
  explicit.  Run "cmake --help-policy CMP0058" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  This project specifies custom command DEPENDS on files in the build tree
  that are not specified as the OUTPUT or BYPRODUCTS of any
  add_custom_command or add_custom_target:

   libgnucash/doc/design/gnucash-design.info

  For compatibility with versions of CMake that did not have the BYPRODUCTS
  option, CMake is generating phony rules for such files to convince 'ninja'
  to build.

  Project authors should add the missing BYPRODUCTS or OUTPUT options to the
  custom commands that produce these files.
This warning is for project developers.  Use -Wno-dev to suppress it.
----

ninja-build dist will fail with this error:
$ ninja-build dist
ninja: error: '/home/janssege/Development/gnucash/gnucash-master/gnucash-
design-info', needed by 'gnucash-2.7.0.tar.gz', missing and no known rule to 
make it

Regards,

Geert