[GNC-dev] Bug 795101 - Scroll Bar in Reconcile Window Floats in and covers the check boxes
Geert Janssens
geert.gnucash at kobaltwit.be
Wed Apr 11 13:29:48 EDT 2018
Op woensdag 11 april 2018 16:52:05 CEST schreef Robert Fewell:
> Would like some thoughts on possible fix...
>
> There seems to be three options but I may of missed something, move the
> toggle reconcile column, make it wider or add a dummy spacer column.
>
> The first may not be liked..
> The last seems a bit over kill.
> So making the column wider seems the best / easiest.
>
> In reconcile-view.c you have the line below which sets the column title...
>
> gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:R")
> + 11);
>
> All I need to do is add a couple of spaces either side of the 'R' which I
> assume I can not do as it would affect the translation string
>
> gnc_search_param_set_title ((GNCSearchParam *) param, _("Reconciled:
> R ") + 11);
>
> But can I add this after above line, it works on my setup, is this OK.
>
> // to allow space for the vertical scrollbar showing, add a couple of
> spaces
> gnc_search_param_set_title ((GNCSearchParam *) param,
> g_strconcat (" ", ((GNCSearchParam *) param)->title, " ",
> NULL));
That would leak a string each time a reconcile view is created (two per
reconcile window).
It also breaks encapsulation. For this to work you need to know the title is
stored in the internal title element or a GNCSearchParam struct. You can get
away with this in C, but it will break when we migrate to C++.
You can do what you want by creating the desired column title before in a
temporary variable and g_free'ing it afterwards.
Regards,
Geert
More information about the gnucash-devel
mailing list