[GNC-dev] Report System Rework

[Carsten Rinke]

Hi,

this takes up a discussion with John and Christopher in PR#360 (and I am 
happy to see that is was merged :-D )

As the discussion turned away from the actual proposal of a test for the 
report definition, I'd suggest to move it to this channel.

John:
You were mentioning that you and Christopher are reworking the report 
system.
I had in mind to create even more PRs with test proposals for the report 
system (in response to Bug787401 which becomes a bit difficult now that 
the bug is closed ;-) ) and I wonder:
Is this idea still worth while?
Do you already have an idea about what is going to change?

Christopher:
Regarding your question below:
I think the report definition is triggered at the very beginning when 
the moduels are loaded.
inner_main triggers libgncmod_report_gnome_gnc_module_init 
(gncmod-report-gnome.c)
this triggers to load guile module "gnucash report standard-reports" 
(standard-report.scm)
this triggers to load all standard  reports
this triggers that (gnc:define-report) is called per report
-> it has nothing to do with html rendering

If you take the changes from PR#360 and comment out the report ID in the 
call to gnc:define-report from any standard report, you will see that an 
"ordinary" pop-up window is created.

-Carsten



-------- Weitergeleitete Nachricht --------
Betreff: 	Re: [Gnucash/gnucash] Bug787401 test report definition (#360)
Datum: 	Thu, 07 Jun 2018 03:47:52 -0700
Von: 	Christopher Lam <notifications at github.com>
Antwort an: 	Gnucash/gnucash 
<reply+026075fc968723c48c7d3e323241b33bf8470a850e163f0c92cf000000011730cf5892a169ce139994a3 at reply.github.com> 

An: 	Gnucash/gnucash <gnucash at noreply.github.com>
Kopie (CC): 	GnuFiBux <carsten.rinke at gmx.de>, Author 
<author at noreply.github.com>



I can understand the need to remove gui calls but not entirely sure 
exactly how the |(gnc:define-report)| is being called. I know they're 
being triggered with every report code e.g. at the end of 
transaction.scm, but not sure what exactly is causing the 
transaction.scm to be run. So, where will the gui error message be 
stated? As a html report perhaps?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub 
<https://github.com/Gnucash/gnucash/pull/360#issuecomment-395377374>, or 
mute the thread 
<https://github.com/notifications/unsubscribe-auth/AmB1_CYCO8c668sE3ZT6LuWkkhfDU2rsks5t6QTYgaJpZM4UYGTI>.