[GNC-dev] Test failure

[Stephen M. Butler]

OH!  Light bulb on!
OK.  I understand what you said earlier.  I'll put the patches back into
the packaging.

Thanks for clearing that up.

--Steve

PS Looking in manual for 'revert' command.



On 1/24/19 1:06 PM, Christopher Lam wrote:
> Because e31f4c3f9 is causing errors on my build as well in different
> ways.
>
> PS e31f4c3f9 must not be reverted for your packaging - please be
> patient while a proper fix is pending.
>
> On 25/1/19 3:48 am, Stephen M. Butler wrote:
>> On 1/24/19 2:32 AM, Christopher Lam wrote:
>>> Stephen this bug is in 3.4 and was fixed in commit 95bee405c
>>>
>>> Could you try "git revert e31f4c3f9" as a test for your "31/12/70"
>>> test-transaction errors?
>>
>> That worked.  Thank you.  BTW, how did you find that it was fixed?  I
>> ask, because there is another one: 01/24/2019
>>
>> -rw-r--r-- 1 steve steve 461 Jan 23 14:16
>> test--skip-test-stress-options.patch
>>
>>   cat test*
>> Last-Update: 2018-10-02
>> Forwarded: not-needed
>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=796877
>> Author: Dmitry Smirnov <onlyjob at member.fsf.org>
>> Description: skip broken test
>>
>> --- a/gnucash/report/standard-reports/test/CMakeLists.txt
>> +++ b/gnucash/report/standard-reports/test/CMakeLists.txt
>> @@ -13,9 +13,8 @@
>>     test-income-gst.scm
>>   )
>>     set(scm_test_with_textual_ports_SOURCES
>> -    test-stress-options.scm
>>   )
>>     set(GUILE_DEPENDS
>>     scm-gnc-module
>>
>> ==================
>>
>> Any way I can search and see if this patch is already in maint?
>>
>>
>>> On 24/1/19 3:05 am, Stephen M. Butler wrote:
>>>> Found this patch on the debian version for 3.4
>>>>
>>>> Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094
>>>> Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008
>>>> Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057
>>>> From: Maxim Cournoyer <maxim.cournoyer at gmail.com>
>>>> Date: Wed, 2 Jan 2019 14:46:28 -0500
>>>> Subject: tests: Fix a test failure in test-transaction.scm.
>>>>
>>>> With the New Year upon us, a test which was hard-coded to use 2018 now
>>>> failed.
>>>>
>>>> Fixes issue #797008 (see:
>>>> https://bugs.gnucash.org/show_bug.cgi?id=797008).
>>>>
>>>> * gnucash/report/standard-reports/test/test-transaction.scm:
>>>> (trep-tests): Use the current year in the test string instead of a
>>>> static one.
>>>>
>>>> --- a/gnucash/report/standard-reports/test/test-transaction.scm
>>>> +++ b/gnucash/report/standard-reports/test/test-transaction.scm
>>>> @@ -4,8 +4,9 @@
>>>>    (use-modules (gnucash report standard-reports transaction))
>>>>    (use-modules (gnucash report stylesheets))
>>>>    (use-modules (gnucash report report-system))
>>>>    (use-modules (gnucash report report-system test test-extras))
>>>> +(use-modules (srfi srfi-19))
>>>>    (use-modules (srfi srfi-64))
>>>>    (use-modules (gnucash engine test srfi64-extras))
>>>>    (use-modules (sxml simple))
>>>>    (use-modules (sxml xpath))
>>>> @@ -642,18 +643,20 @@
>>>>          (set-option! options "General" "Common Currency" #t)
>>>>          (set-option! options "General" "Show original currency
>>>> amount" #t)
>>>>          (set-option! options "Sorting" "Primary Key" 'date)
>>>>          (set-option! options "Sorting" "Primary Subtotal for Date
>>>> Key" 'none)
>>>> -      (let* ((sxml (options->sxml options "dual columns")))
>>>> +      (let* ((sxml (options->sxml options "dual columns"))
>>>> +         (current-year (date->string (current-date) "~y")))
>>>>            (test-equal "dual amount column, with original currency
>>>> headers"
>>>>              (list "Date" "Num" "Description" "Memo/Notes" "Account"
>>>>                    "Debit (USD)" "Credit (USD)" "Debit" "Credit")
>>>>              (get-row-col sxml 0 #f))
>>>>            (test-equal "dual amount column, grand totals available"
>>>>              (list "Grand Total" "$2,280.00" "$2,280.00")
>>>>              (get-row-col sxml -1 #f))
>>>>            (test-equal "dual amount column, first transaction correct"
>>>> -          (list "01/03/18" "$103 income" "Root.Asset.Bank" "$103.00"
>>>> "$103.00")
>>>> +          (list (string-append "01/03/" current-year) "$103 income"
>>>> +        "Root.Asset.Bank" "$103.00" "$103.00")
>>>>              (get-row-col sxml 1 #f)))
>>>>          ) 01/24/2019
>>>>          (test-end "display options")
>>>>
>>>>
>>> _______________________________________________
>>> gnucash-devel mailing list
>>> gnucash-devel at gnucash.org
>>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>>
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


-- 
Stephen M Butler, PMP, PSM
Stephen.M.Butler51 at gmail.com
kg7je at arrl.net
253-350-0166
-------------------------------------------
GnuPG Fingerprint:  8A25 9726 D439 758D D846 E5D4 282A 5477 0385 81D8