[GNC-dev] RE Bug 797085

[Mike Evans]

On Mon, 29 Jul 2019 19:13:27 -0700
John Ralls <jralls at ceridwen.us> wrote:

> > On Jul 29, 2019, at 2:12 AM, Mike Evans <mikee at saxicola.co.uk> wrote:
> > 
> > https://bugs.gnucash.org/show_bug.cgi?id=797085
> > 
> > I've made the strings translatable. Should I do two commits; one for updates to the strings in dialog-bi-import.c and another for updating all the .po files?  The po files update changes a lot of stuff not related to the new strings.  
> 
> If you made a new gnucash.pot and merged it into the po files, discard those changes, we leave that task to translators. The only time we change po files is when we change an already-translated string and want to continue using the existing translations; as a general rule the change needs to be a minor one like fixing a typo. Your commit adds a bunch of new strings so it doesn't qualify.
> 
> Regards,
> John Ralls
> 

Thanks John. After some more thought that's what I decided to do.

Regards

Mike E 




-- 
PGP Key fingerprint = DA68 9657 0FF3 EFCB 58BD  3349 982E 6790 44C1 29D0