[GNC-dev] gnucash master: No gnucash/gettext scm module anymore, the translation defs are in core-utils.

[John Ralls]

> On Apr 15, 2020, at 1:49 AM, Geert Janssens <geert.gnucash at kobaltwit.be> wrote:
> 
> Op dinsdag 14 april 2020 23:22:47 CEST schreef John Ralls:
>> Updated	 via  https://github.com/Gnucash/gnucash/commit/a392190a (commit)
>> 	from  https://github.com/Gnucash/gnucash/commit/2270b851 (commit)
>> 
>> 
>> 
>> commit a392190adf877b552c25936c493c4d63a4a83e8f
>> Author: John Ralls <jralls at ceridwen.us>
>> Date:   Tue Apr 14 14:22:40 2020 -0700
>> 
>>    No gnucash/gettext scm module anymore, the translation defs are in
>> core-utils.
>> 
>> diff --git a/gnucash/gnome-utils/dialog-transfer.c
>> b/gnucash/gnome-utils/dialog-transfer.c index 18defabf0..421f9fd2a 100644
>> --- a/gnucash/gnome-utils/dialog-transfer.c
>> +++ b/gnucash/gnome-utils/dialog-transfer.c
>> @@ -1634,7 +1634,6 @@ new_price(XferDialog *xferData, time64 time)
>>     else if (from == gnc_default_currency() && to !=
>> gnc_default_currency()) value = swap_commodities (&from, &to, value);
>> 
>> -    value = round_price (from, to, value);
> 
> What does this change do. It doesn't seem related to the commit comment.

It fixes a startup crash because price-quotes tried to load a nonexistent module.

Chris had added localization to price-quotes.scm. For that to work in maint he added
  (use-modules (gnucash gettext))
and when I merged maint to master on Monday that got merged too. But you'd removed the gettext module from master and moved the translation definitions (define _()) and (define N_()) to core-utils. That was already used so all that was needed was to remove the gettext module line.

Regards,
John Ralls