[GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

[Phil Longstaff]

I will continue this discussion here because I can no longer comment on the
change on github.

No, I understand you aren't trying to be difficult.

I think when I made the original change, my books were set with a certain
sign-reversal setting and I didn't test with other settings. My problem now
is that I have very little time to spend to fix this. It has been a few
years since I have done anything on the gnucash code base and no longer
have a working development environment.

Phil

On Thu, Jan 2, 2020 at 6:04 AM Christopher Lam <notifications at github.com>
wrote:

> P.S. I'm not intending to be difficult here -- the previous strategy had
> assumed that all budget values asset/liability/income/expense/equity had
> assumed sign-reversal=credit-balances, and was adding/subtracting them as
> such. After bug fix, if this commit, the summary totals would have been
> extremely broken e.g. asset=$300, liability=$1000; the transfer column
> would have shown $1300 or $700 according to sign-reversal preference, and
> the total column would be much more wild.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/Gnucash/gnucash/commit/775200ef348f8579a3e0258988ae25a8026dbd6d?email_source=notifications&email_token=AE6Z25I2JTMG4J3KIZ26GT3Q3XC4FA5CNFSM4KB3HZ4KYY3PNVWWK3TUL52HS4DFVVBW63LNNF2EG33NNVSW45FKMNXW23LFNZ2F62LEZYBC6A6C#commitcomment-36635586>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE6Z25OEXIQVNT5ACQEDTBTQ3XC4FANCNFSM4KB3HZ4A>
> .
>