[GNC-dev] master won't build on Ubuntu 18.04 int-in-bool-context error

[Chris Good]

Hi,

 

I just recreated my eclipse projects (because I did something dumb) and
pulled the latest master (Don't try to unlock the GncDbiSqlConnection when
it was connected read-only
https://github.com/Gnucash/gnucash/commit/b8d514e157fb7bbd1e175b19eb13a3bca0
921788)

But now it won't compile.

 

[170/974] Building CXX object
libgnucash/backend/xml/CMakeFiles/gnc-backend-xml-utils.dir/gnc-xml-backend.
cpp.o

FAILED:
libgnucash/backend/xml/CMakeFiles/gnc-backend-xml-utils.dir/gnc-xml-backend.
cpp.o 

/usr/bin/c++  -DG_LOG_DOMAIN=\"gnc.backend.xml\" -DHAVE_CONFIG_H
-DHAVE_GUILE20 -DU_SHOW_CPLUSPLUS_API=0 -D_GNU_SOURCE
-Dgnc_backend_xml_utils_EXPORTS -I/usr/include/libxml2
-I/home/cgood/gnucash-master/src/libgnucash/backend/xml
-I/home/cgood/gnucash-master/src/libgnucash/engine -Icommon
-I/home/cgood/gnucash-master/src/common -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I/home/cgood/gnucash-master/src/borrowed/libc -Ilibgnucash/core-utils
-I/home/cgood/gnucash-master/src/libgnucash/core-utils
-Wno-error=deprecated-declarations  -Werror -Wall -Wmissing-declarations
-Wno-unused -Wno-error=parentheses  -g -fPIC   -std=c++1z -MD -MT
libgnucash/backend/xml/CMakeFiles/gnc-backend-xml-utils.dir/gnc-xml-backend.
cpp.o -MF
libgnucash/backend/xml/CMakeFiles/gnc-backend-xml-utils.dir/gnc-xml-backend.
cpp.o.d -o
libgnucash/backend/xml/CMakeFiles/gnc-backend-xml-utils.dir/gnc-xml-backend.
cpp.o -c
/home/cgood/gnucash-master/src/libgnucash/backend/xml/gnc-xml-backend.cpp

/home/cgood/gnucash-master/src/libgnucash/backend/xml/gnc-xml-backend.cpp:
In member function 'virtual void GncXmlBackend::session_begin(QofSession*,
const char*, SessionOpenMode)':

/home/cgood/gnucash-master/src/libgnucash/backend/xml/gnc-xml-backend.cpp:12
9:50: error: enum constant in boolean context [-Werror=int-in-bool-context]

                     SESSION_NEW_STORE || mode == SESSION_NEW_OVERWRITE))

                                                  ^~~~~~~~~~~~~~~~~~~~~

cc1plus: all warnings being treated as errors

 

Regards,

Chris Good