[GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

[D.]

Kevin, 

The preferred way to submit changes is through git PRs, not with patch files attached to emails to the lists. You'll get better results using that method. 

David T.


-------- Original Message --------
From: Kevin Buckley <kevin.m.buckley at gmail.com>
Sent: Sun Dec 05 01:35:12 EST 2021
To: "Frank H. Ellenberger" <frank.h.ellenberger at gmail.com>
Cc: gnucash-devel <gnucash-devel at gnucash.org>
Subject: Re: [GNC-dev] Small changes to comment text, mostly in gnucash/import-export/import-main-matcher.h

On Wed, 1 Dec 2021 at 22:40, Frank H. Ellenberger
<frank.h.ellenberger at gmail.com> wrote:
>
> Hi Kevin,
>
> don't forget to CC the list.
>
> Am 01.12.21 um 03:22 schrieb Kevin Buckley:
> > On Sat, 27 Nov 2021 at 23:36, Frank H. Ellenberger
> > <frank.h.ellenberger at gmail.com> wrote:
> >>
> >> Hi Kevin,
> >>
> >> The comments containing "@param" are doxygen sources. How looks the reesult
> >> https://code.gnucash.org/docs/MAINT/import-main-matcher_8h.html and links?
> >>
> >> Regards
> >> Frank
> >
> > Yes the "a the" is visible there too.
> >
> > If I navigate through to, say,
> >
> > https://code.gnucash.org/docs/MAINT/group__Import__Export.html#gad26d36e9e962bb4ba174d697f59f25fb
> >
> > which is the doc for this fucntion
> >
> > gnc_gen_trans_list_empty()
> >
> > I see
> >
> > gboolean gnc_gen_trans_list_empty ( GNCImportMainMatcher *  info)
> >
> > Checks whether there are no transactions to match.
> >
> > Parameters
> > info A pointer to a the GNCImportMainMatcher structure.
> >
> > so the "a the" is in there too.
> >
> > FWIW, I have noticed a few other typos and spelling corrections in
> > the comments, so maybe I should clone the repo and submit a PR
> > with them all in?
>
> Yes, that would be the best approach.
> See also https://wiki.gnucash.org/wiki/Doxygen
>
> Regards
> Frank

Find a patch from a `git diff -p -stat` attached.


------------------------------------------------------------------------

_______________________________________________
gnucash-devel mailing list
gnucash-devel at gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel