[GNC-dev] gnucash-devel Digest, Vol 238, Issue 15

[john]

> On Jan 22, 2023, at 9:21 AM, Bruce Schuck <bschuck at asgard-systems.com> wrote:
> 
> On Sat, 21 Jan 2023 11:09:02 -0800 Joh Ralls wrote:
> 
>> Vincent,
> 
>> The list of F::Q sources displayed in the Security Editor dialog is
>> partially hard-coded in libgnucash/engine/gnc-commodity.c beginning
>> at line 171. Every entry in those two lists represents an F::Q
>> method. At startup GC calls F::Q's `$quoter->sources()` and compares
>> the returned list against the hard-coded lists, enabling the matching
>> entries. Any F::Q methods not in either hard-coded list is added to a
>> new dynamic list that's displayed as the "unknown" list--unknown
>> because at present GnuCash has no way of knowing whether it's a
>> single or a multi-source method--in F::Q terminology whether it has
>> fallbacks. Maintaining that list is a pain in the rear and its
>> existence creates a coupling between GC and F::Q versions. The same
>> applies to modules and API keys and to which module provides which
>> methods.
> 
> .
> .
> .
> 
>> That's a mid-size project. I don't think it will be possible to have
>> it ready for GnuCash 5.0, whose release is only 10 weeks from now
>> with feature freeze in only two weeks. It might be possible to get it
>> into 5.1 at the end of June but I think 5.2 at the end of September
>> is a more realistic goal.
> 
>> See https://wiki.gnucash.org/wiki/CodingStandard and
>> https://wiki.gnucash.org/wiki/C++ for style guidance.
> 
> Gentlemen,
> 
> May I suggest this discussion get moved or copied to the discussion list on https://github.com/finance-quote/finance-quote, possibly https://github.com/finance-quote/finance-quote/discussions/255 or perhaps a new one (In addition I think adding reply+ACHS6J2ATLMJQPWOJZHNSVWBYDZITEVBMXHAAR2XL4 at reply.github.com to the Cc list may copy that discussion). In my opinion the GitHub discussion feature is maybe a better fit for discussing what possible changes may be made to F::Q and underlying modules than the Gnucash-devel mailing list. I think following a discussion may be easier than email list thread/subject archives.
> 
> Thank you John for giving a more detailed description of the GnuCash to Finance::Quote interface and explaining how more thought and planning would benefit both GnuCash and F::Q.

Bruce,

This thread is about GnuCash code and belongs here, at least until Vincent is ready to open a GnuCash PR, at which point the discussion will move to the PR.

I fully expect that as Vincent works on developing the GnuCash side of the code he'll realize that he needs to change the Finance::Quote PR, and those changes will properly be discussed on the Finance::Quote PR.

Regards,
John Ralls