[GNC-dev] gnucash stable: Do a better job of including the -py3 option only for swig 4.1

[Geert Janssens]

Op donderdag 22 februari 2024 13:41:43 CET schreef Derek Atkins:
> I'm going to throw some ideas out there, but... doesn't the "set"
> overwrite the variable??  In the original you had:
> 
>   set DSPF -python -Wall -Werror $(SWIG_ARGS)
>   if (swig_version < 4.1)
>      set DSPF $(SWIG_ARGS) -py3
> 
> Wouldn't this override DSPF if swig is < 4.1, getting rid of -python -Wall
> -Werror?  That would mean that on systems with swig < 4.1, it would not be
> running with -Wall -Werror, but with your new change it WOULD -- causing
> an error on warning where it didn't have one before.
> 

This was my first attempt at making -py3 optional and definitely wrong as I did indeed 
overwrite DSPF. But after that goof up I had already committed a fix that only optionally 
sets -py3 as an additional parameter to DSPF. In the new situation there's only one 'set' 
command to define DSPF in which -py3 optionally comes in via a variable. And that commit 
still bails out with an error while trying to determine the Python site-package directory.

As far as I understand the moment configure fails on python it has not even executed the 
code I have changed. My changes are related to installing swig rules. The failure happens 
much earlier in the configure phase namely while setting up python.

Note also the Ubuntu 22.04 ci tests run fine. Ubuntu 22.04 comes with swig 4.0, hence also 
older than 4.1.

Regards,

Geert