First patch for gnucash

[John Ralls]

Stefan,

Yes, making a PR is exactly the right way to go. I haven’t looked at the code yet and I’ll comment there when I do.

Keeping in mind the pedagogical purpose of improving test coverage I suggest you keep working up the food chain in engine and when you think you’ve got a good enough handle on how that works move to the backends.

Regards,
John Ralls

> On Jan 15, 2026, at 06:48, Stefan Koch <stefan.koch.micro at gmail.com> wrote:
> 
> I think I am ready to propose my first patch for gnucash.  The content
> is full test coverage (almost, see commit message) of the
> libgnucash/engine/qofid.cpp file.  I figured this was a nice small
> commit for me to trial the process on, and for y'all to provide me
> with feedback for all the things I did not know.  The branch also has
> three other commits that cleanup some stuff in the qofid.cpp code.  I
> know the is bold for a hopeful first timer, but please take a look at
> them before passing judgment and feedback.
> 
> I have followed the instructions and made a pull request here:
> https://github.com/Gnucash/gnucash/pull/2169
> 
> Since this is my first time, I thought I would ask here if I am doing
> this right, and how to proceed (other than awaiting github emails for
> the review/merge workflow).
> 
> I am also looking for what to work on next.   I very much like your
> long term plans for the code on this page:
> https://wiki.gnucash.org/wiki/Roadmap.  But I know I am really new to
> this, so adding more testing probably makes more sense before diving
> into those items.  I will pick something myself and start working, but
> if anyone has good ideas, I can look there.
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel