Possible innocuous bug in qofinstance properties.

[John Ralls]

Stefan,

Good catch. Obviously a copy-paste oversight and nearly 20 years old. I don’t see any access to idata via the property, only through the explicit setter and getter, so no real impact. That would explain why nobody noticed.

Would you like to submit a PR or shall I fix it?

Regards,
John Ralls

> On Jan 25, 2026, at 08:46, Stefan Koch <stefan.koch.micro at gmail.com> wrote:
> 
> While trying to learn some of the systems in the source code through writing unit tests, I think I found a bug in the way the qofinstance properties are setup.  (I don't see much usage of this so it may not be an issue in practice.)  
> 
> I think the following change fixes the issue:  
> 
> modified   libgnucash/engine/qofinstance.cpp
> @@ -244,7 +244,7 @@ static void qof_instance_class_init(QofInstanceClass *klass)
>  
>      g_object_class_install_property
>      (object_class,
> -     PROP_EDITLEVEL,
> +     PROP_IDATA,
>       g_param_spec_uint ("idata",
>                          "Object IData",
>                          "Per instance backend private data.",
> 
> Since I am new, I would like to confirm before going on.  
> 
> Stefan
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel