CVS update: gnucash/src/engine

James LewisMoss
15 Feb 2001 14:00:17 -0500

>>>>> On Thu, 15 Feb 2001 11:04:42 -0600 (CST), said:

 linas> It's been rumoured that Dave Peticolas said:
 >> Modified Files: kvp_frame.c Log Message: Fix bugs.

 linas> Um,

 linas> The routines that I added to the kvp code were added so that a
 linas> few uneccessary mallocs could be removed.  The changes that
 linas> you made seem to introduce more than a few mallocs & frees;
 linas> which obviates the need for the new routines in the first
 linas> place.  Although the original code fragmented some, the new
 linas> code fragments worse.  Maybe we should roll back all changes?

They looked like convenience functions to me.  Three copies of the
same code with minor differences.  In fact there are two more after
these three with the same code again.

Also IMO you worry too much about efficiency and reducing mallocs
while at the same time making the code more difficult to understand
and maintain.

Is there a reason you were worried about mallocing here?  Is this code
actually used by anything?


@James LewisMoss <>      |  Blessed Be!
@ |  Linux is kewl!
@"Argue for your limitations and sure enough, they're yours." Bach