Patch

Dave Peticolas dave@krondo.com
27 Dec 2002 14:29:59 -0800


--=-J1QEjCyBJbMCr+oDx/Dy
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 2002-12-27 at 14:10, Peter O'Gorman wrote:
> Hi,
> setlocale LC_ALL "" doesn't work on Mac OS X...
>=20
>=20
> Index: src/scm/main.scm
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/cvs/cvsroot/gnucash/src/scm/main.scm,v
> retrieving revision 1.104
> diff -u -r1.104 main.scm
> --- src/scm/main.scm    9 Dec 2002 06:44:09 -0000       1.104
> +++ src/scm/main.scm    27 Dec 2002 22:08:35 -0000
> @@ -351,7 +351,7 @@
>     (gnc:setup-debugging)
>=20
>     ;; before doing ANYTHING, set the locale!
> -  (setlocale LC_ALL "")
> +  (setlocale LC_ALL "C")

This drastically changes the meaning of this call.

Using "" for the locale tells 'setlocale' to set
up the locale according to the environment variables
(LC_ALL, etc.) the user has set up. Using "C" will
override the user's settings, which is very bad
for non-US users.

It's a pity that Mac OS X doesn't implement this
correctly (it's a POSIX standard), but I think
you ought to find a solution that doesn't break
things for other systems.

dave


--=-J1QEjCyBJbMCr+oDx/Dy
Content-Type: application/DEFANGED-5; name="signature_asc.DEFANGED-5"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA+DNRn5effKKCmfpIRAkvJAJ4gbA1SeUm5ZqvazaIMZBS+x85JgQCfSFm2
2CGTvnd8Eb20OXjlCrtYzsM=
=RzLq
-----END PGP SIGNATURE-----

--=-J1QEjCyBJbMCr+oDx/Dy--