CVS update: gnucash/src/backend/file

Derek Atkins warlord at MIT.EDU
Tue Jul 29 14:11:00 CDT 2003


linas at linas.org (Linas Vepstas) writes:

> On Sat, Jul 26, 2003 at 06:47:29PM -0500, Derek Atkins was heard to remark:
> > 
> > Modified Files:
> > 	gnc-backend-file.c 
> > Log Message:
> > 	* src/backend/file/gnc-backend-file.c: don't make the chmod() and
> > 	  chown() functions fatal errors.  Warn the user if they fail, but
> > 	  don't fail to save.  In the long run we need some way to pop up
> > 	  warning messages from a backend, but until then we'll have to
> > 	  stick with PWARN() and hope users see the console.
> > 	Fixes #118258
> 
> Why can't you just set the error status, the way you did for the unlink
> errors? Somehwere higher up the stack, the gui routines do check for
> errors ... 

Because it's NOT an error -- it's a warning.  Also, I don't think the
error is checked properly if the return value is TRUE, only if it's
FALSE (although I haven't verified this).

The real problem is that the backend function is not continuable..  If
the backend wants user input (due to a warning, or even a continuable
error) then there is no way to warn the user via a dialog and then
continue the process.  There is no way to "continue the process".

> --linas

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the gnucash-patches mailing list