TomF changes for gnucash-gnome2-dev, 8th batch

Linas Vepstas linas at linas.org
Mon Mar 31 21:37:43 CST 2003


On Sun, Mar 30, 2003 at 10:34:19PM -0500, Derek Atkins was heard to remark:
> I just started looking at this patch.  Are you sure this is
> correct:
> 
> -  gtk_object_ref (GTK_OBJECT (notebook->notebook));
> +  g_object_ref (GTK_OBJECT (notebook->notebook));
> 
> In particular, are you sure that g_object_ref() is supposed to get
> passed a GtkObject* pointer?  I just want to make sure this is
> correct before committing.  I would have thought that you would have
> to use G_OBJECT() instead of GTK_OBJECT()...

TomF should reply directly, but my 2 cents:
-- gobject is base class of gtkobject, so it works
-- gnome2 is set up somehow so that this is not a compile error (or didn;'t used 
to be) I think they did this for ease of portability

but yes, it would be more correct to use the G_OBJECT cast

--linas

-- 
pub  1024D/01045933 2001-02-01 Linas Vepstas (Labas!) <linas at linas.org>
PGP Key fingerprint = 8305 2521 6000 0B5E 8984  3F54 64A9 9A82 0104 5933


More information about the gnucash-patches mailing list