MT940 import patch

Christian Stimming stimming at tuhh.de
Wed Sep 17 00:56:11 CDT 2003


-----BEGIN PGP SIGNED MESSAGE-----

On Dienstag, 16. September 2003 17:21, Best, Jan-Pascal van wrote:
> Patch to allow MT940 importing. 

Patch applied. New directory src/import-export/mt940 has been added. Since the 
code in mt940 depends on openhbci being available, I added a configure option 
- --enable-mt940 which is "no" by default. This is because all those 
non-{German,Dutch} developers don't want a broken compile if they don't 
happen to have openhbci installed. If you like you can modify the macros in 
configure.in to actually use the AM_PATH_OPENHBCI macro. 

> Some small changes elsewhere,
> most notably in /src/import-export/hbci/gnc-hbci-gettrans.{h,c}

Yes, that one looks good.

> Oh, and some small compile fixes crept into the patch too
> (src/import-export/hbci/gnc-hbci-kvp.c).

Thanks a lot. I was totally caught by surprise about the broken compile here, 
but then I saw your provided fix -- thanks.

By the way, I run configure with --enable-compile-warnings and 
- --enable-error-on-warning, and with these options I get 

gnc-mt940-import.c: In function `gnc_file_mt940_import':
gnc-mt940-import.c:78: warning: statement with no effect

which, due to the error-on-warning, stops the compile. Do you happen to have a 
different code proposal for that line? On the other hand this is really only 
a minor issue.

Thanks a lot for your contribution.

Christian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iQCVAwUBP2eG+2XAi+BfhivFAQH52AQAhhx0ci3t3SH0u6Sd6sIlGLRD3dWMjCLI
g4U86fHSVSRtzHDwDdKxXj+9PNr+xJk9SYiAcK8sPD/Kn7sKhrDFS7t6+Gzsrx30
JFwo2mJ4DFLRh4CRl4DQhaUlLhEW5Uy2lMhnA88ONVdvi+7nW9E+NOLONvK7J4tr
VpfCriUfPec=
=R0QX
-----END PGP SIGNATURE-----



More information about the gnucash-patches mailing list