MT940 import patch

Best, Jan-Pascal van j.p.vanbest at tbm.tudelft.nl
Wed Sep 17 16:11:56 CDT 2003


Christian wrote:
> Patch applied. New directory src/import-export/mt940 has been 
> added. Since the 
> code in mt940 depends on openhbci being available, I added a 
> configure option 
> - --enable-mt940 which is "no" by default. This is because all those 
> non-{German,Dutch} developers don't want a broken compile if 
> they don't happen to have openhbci installed. If you like you can modify 
> the macros in configure.in to actually use the AM_PATH_OPENHBCI macro. 

Let's just leave it like this. Maybe someday the default should be "on" 
if openhbci is available, but I'm not really into auto{conf,header,local,make}.
 
> By the way, I run configure with --enable-compile-warnings and 
> - --enable-error-on-warning, and with these options I get 
> 
> gnc-mt940-import.c: In function `gnc_file_mt940_import':
> gnc-mt940-import.c:78: warning: statement with no effect
> 
> which, due to the error-on-warning, stops the compile. Do you happen to have a 
> different code proposal for that line? On the other hand this is really only 
> a minor issue.

Yes, I have a proposal: just remove the line. It was copied from the ofx
importer, and it seems to have been removed there, too.

> Thanks a lot for your contribution.
Just scratching my own itch...

Jan-Pascal


More information about the gnucash-patches mailing list