Summarybar patch

[Derek Atkins]

Just looked at this.  In general I think it's good, but I have one
comment.  It probably would have been better if you abstracted out
gnc:options-add-report-date! and gnc:options-add-date-interval!  from
options-utilities.scm so we have a single place where we define a date
option.

The rest of the patch looks fine.

So, do you think you could abstract out the date options API and
resubmit?  Or just send me another patch based off this one that
implements that?

-derek

Herbert Thoma <tma at iis.fhg.de> writes:

> I added some options to the summarybar, patches for head and stable branch
> attached.
>
>  Herbert.
>
> 	* src/app-utils/global-options.c:
> 	* src/app-utils/global-options.h: add gnc_lookup_date_option()
> 	  function
> 	* src/app-utils/gnc-ui-util.c:
> 	* src/app-utils/gnc-ui-util.h: add 
> 	  gnc_ui_account_get_balance_in_currency() function
> 	* src/app-utils/prefs.scm: add preferences for summarybar
> 	* src/engine/Account.c:
> 	* src/engine/Account.h: add 
> 	  xaccAccountConvertBalanceToCurrencyAsOfDate() function
> 	* src/gnome/window-main-summarybar.c: summarybar can now display
> 	  a grand total of all commodities, profits of a period of time
> 	  and net assets at the end of the period; summarybar can be
> 	  configured with some options under edit->preferences
>
>
> _______________________________________________
> gnucash-patches mailing list
> gnucash-patches at lists.gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available