druid-merge, qof_book_merge and druid-hierarchy

Neil Williams linux at codehelp.co.uk
Sun Oct 31 18:36:14 EST 2004

On Sunday 31 October 2004 7:36 pm, you wrote:
> > I should note that in the future could you reduce the amount of
> > white-space style changes in your patches?  I've applied this one
> > wholesale, but it's best if you try not to reformat existing code.

I think I've solved that for future with .cvsrc and .makepatchrc - to use 
diff -pub 
instead of just -pu.

I did try changing the editor settings, must have been something on trailing 
whitespace or tab->space conversion which diff should now ignore.

> Oh, another question for you:  Is there some particular reason you
> export the "qofAccountSetParent()" api?  It's only used in the
> QOF Object settings, right?

Yes, it doesn't really have much use outside QofObject.

> That means you could define it as a 
> static function and not export it in the public API...

Thanks, I missed that.


Neil Williams

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-patches/attachments/20041031/be38ffbe/attachment.bin

More information about the gnucash-patches mailing list