r12199 - gnucash/trunk/src/engine - Single-pass audit/cleanup of Account.c

[Chris Shoemaker]

Author: chris
Date: 2005-12-29 17:22:33 -0500 (Thu, 29 Dec 2005)
New Revision: 12199
Trac: http://svn.gnucash.org/trac/changeset/12199

Modified:
   gnucash/trunk/src/engine/Account.c
   gnucash/trunk/src/engine/Account.h
Log:
Single-pass audit/cleanup of Account.c

 * standardize on 'acc' as variable name for Account.
 * removed 'acc->inst.dirty = TRUE' when preceeded by mark_account.
 * slightly more consistent whitespace.
 * short-circuit no-op in many cases where we thought we were changing state but we really weren't.  Don't dirty Accounts in these cases.
 * fix a couple cases where we dirtied the account without dirtying the parent
 * fix one BUG where we just blew away the account's Lots for no reason.
 * comment possible bug where we don't dirty a split.
 * comment two possible buglets where we generate double CM events.
 * comment on possible bugs related to conditional sorting of the Split list.
 * heavy conversion from lower-level to higher-level KVP api.
 * plug mem leak of entire GList of splits.
 * document minor change to corner-case behavior of xaccAccountHasAncestor().
 * several control flow simplifications.
 * fixed one case where we were changing the Account without dirtying it. (Can't find this one now.  Maybe I imagined it.)

Please note where I've marked 'BUG'.  I think there are still (at
least) 2 medium and 2 minor bugs remaining in this file.  I'll have
another look some other day.