HEAD - QOF sync patch.

Derek Atkins warlord at MIT.EDU
Sun Jan 30 11:05:05 EST 2005


Unfortunately this patch also breaks a bunch of the C99 changes
that were put into the code.  For example, this patch is just wrong:

--- ./src/engine/test-core/test-engine-stuff.c  Fri Dec 17 15:56:30 2004
+++ ./src/engine/test-core/test-engine-stuff.c  Mon Dec 20 15:01:29 2004
@@ -873,17 +873,14 @@ add_random_splits(QofBook *book, Transac
 {
     Account *acc, *bcc;
     Split *s;
-    gnc_commodity *com;
-    int scu;
-    gnc_numeric num;
 
     /* Gotta have at least two different accounts */
     if (1 >= g_list_length (account_list)) return;
 
     /* Set up two splits whose values really are opposites. */
-    com = xaccTransGetCurrency (trn);
-    scu = gnc_commodity_get_fraction(com);
-    num = get_random_gnc_numeric();
+    gnc_commodity *com = xaccTransGetCurrency (trn);
+    int scu = gnc_commodity_get_fraction(com);
+    gnc_numeric num = get_random_gnc_numeric();

Are you sure you were working from an up-to-date cvs tree?  Also,
unless you're adding new files you're MUCH MUCH MUCH better off just
sending in a "cvs diff -q" output.  It's shorter and less prone to
errors like these.

-derek

Neil Williams <linux at codehelp.co.uk> writes:

> This patch brings gnucash HEAD into sync with my latest work on QOF and 
> includes numerous changes to put the variable definitions at the top of the 
> functions. It also brings qof_book_merge up to date and fixes the problem 
> with the test-book-merge.c rule updates that is fixed in g2 with the other 
> patch.
>
> A redundant loop in druid-merge.c is also removed.
>
> This patch also fixes:  (QofAccessFunc)xaccAccountSetNonStdSCU
> in src/engine/Account.c - that's a Set routine allocated as a QofAccessFunc - 
> the patch changes it to the appropriate Get routine - the QofSetterFunc is 
> OK.
>
> Unfortunately, that was missed in the g2 patch - the same bug exists. A 
> smaller patch is on it's way to fix that.
>
> -- 
>
> Neil Williams
> =============
> http://www.dcglug.org.uk/
> http://www.nosoftwarepatents.com/
> http://sourceforge.net/projects/isbnsearch/
> http://www.neil.williamsleesmill.me.uk/
> http://www.biglumber.com/x/web?qs=0x8801094A28BCB3E3
>
>
> _______________________________________________
> gnucash-patches mailing list
> gnucash-patches at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the gnucash-patches mailing list