updating qofAccountSetParent

Derek Atkins warlord at MIT.EDU
Sun Jan 30 17:49:00 EST 2005


Yea, I finally read the patch.  I'll note that this change needed to
go into both HEAD _AND_ g2 -- so you failed to this change in all of
your patches.

The problem with using "makepatch" is that it requires two full source
trees; one that matches CVS, and one with your local changes.  When
using "cvs diff" you only need one tree, your local tree with your
changes.  The second tree is the version in CVS.

-derek

Neil Williams <linux at codehelp.co.uk> writes:

> On Sunday 30 January 2005 10:25 pm, you wrote:
>> This patch shouldn't be necessary.  The function is already static in CVS
>> HEAD.
>
> It's not the static declaration that's the problem, the body of the function 
> hasn't been updated:
>
>> The separate patch for the QofAccessFunc has meant that the changes 
>> WITHIN qofAccountSetParent have been omitted from the patch. I'm sending in 
>> another patch for Account.c that brings qofAccountSetParent properly into 
>> sync.
>
>> > Sorry to put a third patch onto Account.c but with the conversion of the
>> > earlier patch to cvs -q diff, the internals of the function did NOT get
>> > patched.
>
> The declaration is fine, the body of the function is not.
>
>> >
>> > This became obvious when the function complained about needing to be
>> > static -
>> >
>> > it IS static but that change has so far not made it into the commit.
>
> -- 
>
> Neil Williams
> =============
> http://www.dcglug.org.uk/
> http://www.nosoftwarepatents.com/
> http://sourceforge.net/projects/isbnsearch/
> http://www.neil.williamsleesmill.me.uk/
> http://www.biglumber.com/x/web?qs=0x8801094A28BCB3E3
>

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the gnucash-patches mailing list