[patch 2/4] minor signedness fixups

c.shoemaker at cox.net c.shoemaker at cox.net
Fri Jul 22 14:16:30 EDT 2005


 * gcc4 warns about signedness mismatches, and there are some places
where we could be more explicit about the signedness of our chars.


 backend/qsf/qsf-xml-map.c            |    4 ++--
 engine/guid.c                        |    2 +-
 engine/test-core/test-engine-stuff.c |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

Index: gnucash/src/backend/qsf/qsf-xml-map.c
===================================================================
--- gnucash.orig/src/backend/qsf/qsf-xml-map.c
+++ gnucash/src/backend/qsf/qsf-xml-map.c
@@ -317,9 +317,9 @@ qsf_map_top_node_handler(xmlNodePtr chil
 	}
 }
 
-static char*
+static xmlChar*
 qsf_else_set_value(xmlNodePtr parent, GHashTable *default_hash,
-		char *content, xmlNsPtr map_ns)
+                   xmlChar *content, xmlNsPtr map_ns)
 {
 	xmlNodePtr cur_node;
 
Index: gnucash/src/engine/guid.c
===================================================================
--- gnucash.orig/src/engine/guid.c
+++ gnucash/src/engine/guid.c
@@ -290,7 +290,7 @@ init_from_int(int val)
 }
 
 static size_t
-init_from_buff(char * buf, size_t buflen)
+init_from_buff(unsigned char * buf, size_t buflen)
 {
   md5_process_bytes(buf, buflen, &guid_context);
   return buflen;
Index: gnucash/src/engine/test-core/test-engine-stuff.c
===================================================================
--- gnucash.orig/src/engine/test-core/test-engine-stuff.c
+++ gnucash/src/engine/test-core/test-engine-stuff.c
@@ -251,12 +251,12 @@ get_random_binary_data(void)
 
     len = get_random_int_in_range(20,100);
     ret = g_new(bin_data, 1);
-    ret->data = g_new(char, len);
+    ret->data = g_new(guchar, len);
     ret->len = len;
 
     for(len--; len >= 0; len--)
     {
-        ret->data[len] = (char)get_random_int_in_range(0,255);
+        ret->data[len] = (guchar)get_random_int_in_range(0,255);
     }
 
     return ret;

--


More information about the gnucash-patches mailing list