Fix cursor display in register window

Josh Sled jsled at asynchronous.org
Sun Oct 2 19:02:29 EDT 2005


On Sun, 2005-10-02 at 17:57 +0200, Didier Vidal wrote:
>  cvs -q diff -u gnucash-item-edit.c
> Index: gnucash-item-edit.c
> ===================================================================
> RCS file:
> /home/cvs/cvsroot/gnucash/src/register/register-gnome/gnucash-item-edit.c,v
> retrieving revision 1.1.6.12
> diff -u -r1.1.6.12 gnucash-item-edit.c
> --- gnucash-item-edit.c 15 Aug 2005 23:34:38 -0000      1.1.6.12
> +++ gnucash-item-edit.c 2 Oct 2005 15:52:55 -0000
> @@ -80,7 +80,7 @@
>   
>          gboolean hatching;
>   
> -       PangoRectangle *cursor;
> +       PangoRectangle cursor;
>  };
>   
>   
> @@ -226,7 +226,7 @@
>         }
>   
>         pango_layout_get_cursor_pos (info->layout, cursor_pos, NULL,
> &strong_pos);
> -       info->cursor = &strong_pos;
> +       info->cursor = strong_pos;


It's probably better to attach these as files to the message rather than
in-lining them; the line-wrapping near "&strong_pos" above caused the
patch to reject, and a bit of pain to edit, &c..  No problem at all,
just fyi.

Also, there was weirdness that I simply could not explain in applying
this gnucash-item-edit.c patch ... I thought it was a space-vs-tab issue
(your patch appears to have just spaces, but the source file has tabs),
but even after eliminating that difference, patch simply refused to
apply it.  I ended up making the same changes by hand.

Thanks for the patches!

...jsled
-- 
http://asynchronous.org/ - `a=jsled; b=asynchronous.org; echo ${a}@${b}`


More information about the gnucash-patches mailing list