r13461 - gnucash/trunk/src/engine - The xaccTransRollbackEdit() part of the Begin/Commit edit-block rewrite.

Chris Shoemaker chris at cvs.gnucash.org
Fri Mar 3 19:11:17 EST 2006


Author: chris
Date: 2006-03-03 19:11:16 -0500 (Fri, 03 Mar 2006)
New Revision: 13461
Trac: http://svn.gnucash.org/trac/changeset/13461

Modified:
   gnucash/trunk/src/engine/Transaction.c
Log:
   The xaccTransRollbackEdit() part of the Begin/Commit edit-block rewrite.  
   Broken out just for clarity.

   Note: There's one piece that I didn't change that I think is conceptually
   awkward.  It has to do with how/when we would discover that another
   user has deleted the transaction we're currently editing.  I think it makes
   more sense to detect and handle this case in xaccTransCommitEdit() instead
   of xaccTransRollbackEdit(), because (a) we don't actually have to do the 
   rollback if we just destroy the trans, (b) some rollbacks are not backend-
   induced, but rather voluntary, (c) we need a generalized mechanism
   anyway for detecting and handling deleted transactions even when
   we're not editing them.





More information about the gnucash-patches mailing list