r15136 - gnucash/branches/2.0 - Fix auto-completion/pending transactions. #348469.
Derek Atkins
warlord at cvs.gnucash.org
Fri Nov 24 13:42:37 EST 2006
Author: warlord
Date: 2006-11-24 13:42:35 -0500 (Fri, 24 Nov 2006)
New Revision: 15136
Trac: http://svn.gnucash.org/trac/changeset/15136
Modified:
gnucash/branches/2.0/
gnucash/branches/2.0/ChangeLog
gnucash/branches/2.0/src/register/ledger-core/split-register-control.c
gnucash/branches/2.0/src/register/ledger-core/split-register.c
Log:
Fix auto-completion/pending transactions. #348469.
Ensure that the blank transaction is marked as the pending
transaction when it is modified. This fixes a bug where editing
the blank transaction, moving off of the transaction line to a
split line, leaving the split line unedited and then closing the
register will incorrectly leave the transaction open without
asking. The bug fixed by this commit is possibly responsible for
some of the crashes like bug #348469.
This fixes a bug in r14495. The bug is that auto-completed
transactions aren't correctly marked as pending. This bug is
probably responsible for the crashes like those in bug #348469.
In general, the register makes it very difficult to consistently
distiguish between beginning to edit a transaction that's being
edited in another register and beginning to edit the blank
transaction, which is already open for editing, but isn't marked
pending so that we can pretend it hasn't been opened if it never
gets modified.
Fortunately, the auto-completion code only runs on the blank
transaction, so we can assume it's not being edited in another
register. This patch goes ahead and marks the blank transaction
as pending.
Merge r15002 and r15004.
More information about the gnucash-patches
mailing list