r17889 - gnucash/trunk/src - Bug#139310: Store online_id in split instead of transaction to avoid import conflicts

Christian Stimming cstim at cvs.gnucash.org
Tue Feb 10 16:16:22 EST 2009


Author: cstim
Date: 2009-02-10 16:16:22 -0500 (Tue, 10 Feb 2009)
New Revision: 17889
Trac: http://svn.gnucash.org/trac/changeset/17889

Modified:
   gnucash/trunk/src/engine/kvp_doc.txt
   gnucash/trunk/src/import-export/aqbanking/gnc-ab-utils.c
   gnucash/trunk/src/import-export/hbci/gnc-hbci-gettrans.c
   gnucash/trunk/src/import-export/import-backend.c
   gnucash/trunk/src/import-export/import-utilities.c
   gnucash/trunk/src/import-export/import-utilities.h
   gnucash/trunk/src/import-export/ofx/gnc-ofx-import.c
Log:
Bug#139310: Store online_id in split instead of transaction to avoid import conflicts

Affects all users of the generic import: OFX, HBCI and AqBanking.

Suggested by <http://bugzilla.gnome.org/show_bug.cgi?id=139310>.
"
 Assume you have a transaction that transfers money from account 1 to account 2.
 Import an OFX statement from account 1 that matches the transaction.  Then
 import an OFX statement from account 2 that matches the same transaction.
 Because each transaction can only store one online_id, when you import from
 account 1 again it doesn't remember that it's already been imported.

 If online_id was stored in a split slot instead of a transaction slot, it would
 allow tracking the online_id of both accounts without being overwritten.
"

For backwards compatibility, we still check for online_id in transactions.
This is more of a convenience than a critical feature, however.
The compatibility code could be removed in future versions if desired.

Patch by Alan Jenkins <alan-jenkins at tuffmail.co.uk>



More information about the gnucash-patches mailing list