r19904 - gnucash/trunk - Bug #635859: Strip all trailing '/'es from kvp_slot paths when loading.

John Ralls jralls at code.gnucash.org
Fri Dec 3 18:24:34 EST 2010


Author: jralls
Date: 2010-12-03 18:24:34 -0500 (Fri, 03 Dec 2010)
New Revision: 19904
Trac: http://svn.gnucash.org/trac/changeset/19904

Modified:
   gnucash/trunk/po/POTFILES.in
   gnucash/trunk/src/backend/dbi/gnc-backend-dbi.c
   gnucash/trunk/src/backend/sql/gnc-slots-sql.c
   gnucash/trunk/src/bin/gnucash-bin.c
   gnucash/trunk/src/gnome-utils/gnc-gnome-utils.c
Log:
Bug #635859: Strip all trailing '/'es from kvp_slot paths when loading.

This changes round-tripping slightly (because the resulting slot key
won't have the trailing slash when it's re-saved as xml). It may also
change the behavior of the facility using the slot, because the key is
changed. So far, the only known instances which trip this bug are
import-map-bayes, because descriptions may have '/'es in them (and why
shouldn't they).

Unfortunately, fixing this right (so that key values can have embedded
'/''es and be saved/retrieved from sql databases will require changing
the slot architecture in ways that impact the engine. Since we don't
have adequate unit tests to be confident of not introducing a
regression, I'm applying this instead.





More information about the gnucash-patches mailing list