r18699 - gnucash/trunk - Ensure that GNC_DOT_PATH and other gnc_dotgnucash_dir() logic is

[John Ralls]

Author: jralls
Date: 2010-02-20 17:01:05 -0500 (Sat, 20 Feb 2010)
New Revision: 18699
Trac: http://svn.gnucash.org/trac/changeset/18699

Modified:
   gnucash/trunk/AUTHORS
   gnucash/trunk/src/bin/gnucash-setup-env-osx.in
   gnucash/trunk/src/engine/gnc-filepath-utils.c
   gnucash/trunk/src/engine/gnc-filepath-utils.h
Log:
    Ensure that GNC_DOT_PATH and other gnc_dotgnucash_dir() logic is
    used for all cases, remove hard-coded references to /usr/etc,
    /usr/share, /usr/local/etc, and /usr/local/share while providing
    for xaccResolveFilePath to actually search the data and sysconfdir
    directories used in the build.
    
    (gnc_build_data_path): New function, just a copy of
    gnc_build_book_path. Needed for rewrite of xaccResolveFilePath.
    (xaccResolveFilePath): Cleaned out the hard-coded paths and weird
    file path contruction functions and rewrote the function to use
    gnc_path_get_foo and gnc_build_data_path without all of the silly
    indirection. Removed superfluous URI checks (which are correctly
    perfomed by xaccResolveURL()).
    (MakeHomeDir, xaccPathGenerator, xaccDataPathGenerator)
    (xaccUserPathGenerator): Deleted; their functionality is replaced
    as noted above.

    (check_file_return_if_true): Renamed check_file_return_if_valid, a
    more descriptive name.