gnucash master: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Thu Aug 7 16:26:24 EDT 2014
Updated via https://github.com/Gnucash/gnucash/commit/d20dcb46 (commit)
via https://github.com/Gnucash/gnucash/commit/95925126 (commit)
via https://github.com/Gnucash/gnucash/commit/4e7e52a3 (commit)
via https://github.com/Gnucash/gnucash/commit/e4d97f6d (commit)
via https://github.com/Gnucash/gnucash/commit/551e5c60 (commit)
via https://github.com/Gnucash/gnucash/commit/c286448f (commit)
via https://github.com/Gnucash/gnucash/commit/46455c75 (commit)
via https://github.com/Gnucash/gnucash/commit/321a159a (commit)
via https://github.com/Gnucash/gnucash/commit/b465fef9 (commit)
via https://github.com/Gnucash/gnucash/commit/56af86c0 (commit)
via https://github.com/Gnucash/gnucash/commit/163acb86 (commit)
via https://github.com/Gnucash/gnucash/commit/1e5b14b5 (commit)
via https://github.com/Gnucash/gnucash/commit/28e1d1a8 (commit)
via https://github.com/Gnucash/gnucash/commit/c146e210 (commit)
via https://github.com/Gnucash/gnucash/commit/9711ae24 (commit)
via https://github.com/Gnucash/gnucash/commit/726ab02d (commit)
via https://github.com/Gnucash/gnucash/commit/ce94872e (commit)
via https://github.com/Gnucash/gnucash/commit/cbc292cc (commit)
via https://github.com/Gnucash/gnucash/commit/f40a93c6 (commit)
via https://github.com/Gnucash/gnucash/commit/30fac05e (commit)
via https://github.com/Gnucash/gnucash/commit/2a408ab9 (commit)
via https://github.com/Gnucash/gnucash/commit/9c82a1e9 (commit)
via https://github.com/Gnucash/gnucash/commit/26a49f96 (commit)
from https://github.com/Gnucash/gnucash/commit/d5fa5486 (commit)
commit d20dcb46486a90d1864f11250428df51ec9a1ae8
Merge: 9592512 163acb8
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 13:09:57 2014 -0700
Merge branch 'guidcpp'
Incorporate Aaron Laws's reimplementation of gncguid with boost::guid.
commit 959251265ac922d55719f1f34cf12a8cebb53f5b
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 4 14:18:39 2014 -0700
Add gnc-date.cpp to POTFILES.in
Because make check complained. Dunno what changed...
commit 4e7e52a31167ec108ffcd73b22438a4245131b0d
Merge: d5fa548 e4d97f6
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 11:47:27 2014 -0700
Merge branch 'maint'
commit e4d97f6d7466f1c0bd74785bf5cc450f08c794ba
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 11:46:17 2014 -0700
Fix test-backend-dbi segfault with libdbi-0.9.0.
dbi_inst must be initialized before it can be used.
commit 551e5c6093f22aeee29561cae1f4c34150e5d093
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 11:45:40 2014 -0700
Fix uninitialized variable warning.
commit c286448fdb6f9cbbbff42f2ab73f5291168111f1
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 11:41:21 2014 -0700
Add note about automake 1.14 to configure.ac
The note has the details, but I wasn't able to get gnucash to build with
automake 1.14 without passing --disable-dependency-tracking regardless of
whether I used the subdir-objects option. If I could figure out a good way
to poison configure with automake 1.14 I would.
commit 46455c75185f4ac04922dc6ab7f8b8094e55b9c9
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 10:23:50 2014 -0700
Revert "Fix broken test-backend-dbi with libdbi 0.9."
This reverts commit 321a159af29a9b51fe793c2528dccb74b0443bf9.
Got two unrelated changes into a single changeset.
commit 321a159af29a9b51fe793c2528dccb74b0443bf9
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Aug 7 10:00:39 2014 -0700
Fix broken test-backend-dbi with libdbi 0.9.
Segfaulted for an uninitialized dbi_instance.
commit b465fef9ac9ad615a5a90018dec685a3379ff03b
Author: Mike Evans <mikee at millstreamcomputing.co.uk>
Date: Thu Aug 7 16:00:38 2014 +0100
Bug 734183 - Set all of the denominators correctly on the currency values.
commit 56af86c0a27cf07e5740c63dba1fdf3a69a2d549
Author: Mike Evans <mikee at millstreamcomputing.co.uk>
Date: Sun Aug 3 14:51:06 2014 +0100
Bill invoice importer crashing when invoice has multiple lines.
Move the final g_free(s) outside the while loop.
commit 163acb863d4a97bf94d61528f4a9819c4524a665
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 4 15:06:02 2014 -0700
Two minor tweaks to pass make check.
commit 1e5b14b54f49d7ab7f74a800de7266001ad91964
Merge: 28e1d1a 9711ae2
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 4 14:35:23 2014 -0700
Merge branch 'guidcpp' of https://github.com/limitedAtonement/gnucash
into guidcpp
commit 28e1d1a8c2782826c9b09d4e8d3b935d759ddb19
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 4 14:18:39 2014 -0700
Add gnc-date.cpp to POTFILES.in
Because make check complained. Dunno what changed...
commit c146e210438b5878374aadd6be9f413ebf66e65d
Author: John Ralls <jralls at ceridwen.us>
Date: Mon Aug 4 14:09:22 2014 -0700
Replace built-in md5 hashing with GChecksum
Prepare for removing it when we replace the GncGUID implementation with Boost.
commit 9711ae244664bb5b6fb2f85bcafcfb526ca2c7a0
Author: lmat <dartme18 at gmail.com>
Date: Wed Jul 30 11:57:36 2014 -0400
Added new tests.
Added tests for string_to_guid and guid_replace.
commit 726ab02d651e10c520dba895d368b0760f3396e2
Author: lmat <dartme18 at gmail.com>
Date: Mon Jul 28 17:03:07 2014 -0400
Simplified some of the GUID code.
This change applies some recommendations from jralls. It better utilizes for loops,
and usage of swap. We also try to make sure the null guid is not freed since it's
reused, and catch a c++ exception to make sure it doens't escape into C code when
parsing a GUID.
commit ce94872ec86c37fb49660004f97d0ce65905c475
Author: lmat <dartme18 at gmail.com>
Date: Mon Jul 28 16:52:22 2014 -0400
Cleaned up some code and comments.
There should be no impacting changes in this commit.
commit cbc292cc91718ce5fb45b7b2e4ce70c74ef1c556
Author: lmat <dartme18 at gmail.com>
Date: Mon Jul 28 11:15:28 2014 -0400
Removed the md5 file and updated the build system.
We no longer need md5.h or md5.c because all that work is done in the boost
uuid implementation.
commit f40a93c6e1b27acaf7fd32bfca4c64ea27a2a860
Author: lmat <dartme18 at gmail.com>
Date: Fri Jul 25 17:38:33 2014 -0400
Remove guid_init and guid_shutdown
They no longer do anything, and it's not probable that they ever will.
commit 30fac05e35b41d316ba9d8f93474879e196c3cbb
Author: lmat <dartme18 at gmail.com>
Date: Fri Jul 25 17:02:44 2014 -0400
Corrected uses of guid_to_string.
Previously, guid_to_string had been marked deprecated with a note about
it not being thread-safe. It was much worse than "not thread safe", it
was only safe in a particular situation, and its safety was being violated
throughout the code. It was clear that users of guid_to_string did not
understand what it was purporting to do because of its varied uses. Most
uses simply treated it like a Garbage-Collected Java String (use and forget).
I actually found at least one instance where the string was being freed. (!!!)
I made the method have a particular easy-to-understand semantic: it returns
a pointer to a string which must be freed by the caller. I then tried to
track down all uses of this function and correct them. Mostly, I just changed
the usage to guid_to_string_buff with a stack-allocated string to avoid the
the malloc/free cycle.
commit 2a408ab9ef31031440d1877673baad509ab085c3
Author: lmat <dartme18 at gmail.com>
Date: Fri Jul 25 14:14:09 2014 -0400
Cleared up GUID construction and allocation
To allocate a GUID, use guid_malloc. To allocate and construct a guid
(which is actually unique), use guid_new (and be sure to free it using
guid_free).
commit 9c82a1e9bc217cc2c12482c3e23b0d442a5f0661
Author: lmat <dartme18 at gmail.com>
Date: Fri Jul 25 08:26:54 2014 -0400
Rename guid_new to guid_replace
`new` implies some allocation. Since guid_new was actually constructing
a guid in place rather than allocating it, it makes much more sense to
call it guid_replace (or guid_construct). We went with guid_replace.
commit 26a49f96443cf2039834ea4793482021f68a4885
Author: lmat <dartme18 at gmail.com>
Date: Wed Jun 11 09:17:09 2014 -0400
Implement GUID using boost's implementation
Since we're maintaining a C api, the implementation is sometimes less than
intuitive from either a C or C++ perspective. I am trying to use as much
boost as possible while making all the guarantees that the C code makes.
One function was declared deprecated because it "wasn't thread safe". This
was straightforward to repair, and is no longer marked deprecated, and there
are now two ways to convert GUID to String: passing your own character
buffer, and having one returned to you that you need to free.
Summary of changes:
configure.ac | 10 +-
po/POTFILES.in | 2 +-
src/app-utils/gnc-component-manager.c | 4 +-
src/app-utils/gnc-state.c | 5 +-
src/app-utils/gnc-sx-instance-model.c | 10 +-
src/app-utils/guile-util.c | 11 +-
src/app-utils/test/test-scm-query-string.c | 1 -
src/backend/dbi/test/test-backend-dbi-basic.c | 5 +-
src/backend/sql/gnc-transaction-sql.c | 18 +-
src/backend/xml/gnc-bill-term-xml-v2.c | 44 +-
src/backend/xml/gnc-schedxaction-xml-v2.c | 11 +-
src/backend/xml/gnc-tax-table-xml-v2.c | 20 +-
src/backend/xml/sixtp-dom-generators.c | 8 +-
src/backend/xml/test/test-xml-transaction.c | 4 +-
src/business/business-gnome/dialog-invoice.c | 13 +-
src/doc/design/engine.texi | 24 +-
src/engine/SchedXaction.c | 4 +-
src/engine/Split.c | 4 +-
src/engine/Transaction.c | 6 +-
src/engine/gncBillTerm.c | 5 +-
src/engine/test-core/test-engine-stuff.c | 2 +-
src/engine/test/test-customer.c | 2 +-
src/engine/test/test-employee.c | 2 +-
src/engine/test/test-guid.c | 7 +-
src/engine/test/test-job.c | 2 +-
src/engine/test/test-vendor.c | 2 +-
src/engine/test/utest-Split.cpp | 4 +-
src/experimental/cgi-bin/gnc-server.c | 13 +-
src/gnome/dialog-print-check.c | 2 +-
src/gnome/dialog-print-check2.c | 2 +-
src/gnome/dialog-sx-editor.c | 4 +-
src/gnome/dialog-sx-editor2.c | 3 +-
src/gnome/gnc-budget-view.c | 9 +-
src/gnome/gnc-plugin-page-account-tree.c | 10 +-
src/gnome/gnc-split-reg.c | 28 +-
src/gnome/gnc-split-reg2.c | 37 +-
src/gnome/top-level.c | 4 +-
src/import-export/aqb/gnc-gwen-gui.c | 25 +-
src/import-export/log-replay/gnc-log-replay.c | 9 +-
src/libqof/qof/Makefile.am | 9 -
src/libqof/qof/guid.cpp | 730 ++++----------------------
src/libqof/qof/guid.h | 118 ++---
src/libqof/qof/kvp_frame.cpp | 6 +-
src/libqof/qof/md5.c | 445 ----------------
src/libqof/qof/md5.h | 163 ------
src/libqof/qof/qofinstance.cpp | 7 +-
src/libqof/qof/qofquery.cpp | 6 +-
src/libqof/qof/qofutil.cpp | 2 -
src/libqof/qof/qofutil.h | 6 +-
src/libqof/qof/test/test-gnc-guid.cpp | 57 +-
src/libqof/qof/test/test-kvp_frame.c | 36 +-
src/libqof/qof/test/test-qofinstance.c | 3 +-
src/plugins/bi_import/dialog-bi-import.c | 93 ++--
53 files changed, 478 insertions(+), 1579 deletions(-)
delete mode 100644 src/libqof/qof/md5.c
delete mode 100644 src/libqof/qof/md5.h
More information about the gnucash-patches
mailing list