gnucash maint: Multiple changes pushed

Geert Janssens gjanssens at
Sat Nov 12 05:07:28 EST 2016

Updated	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit ecb43e7d72941c32bc7bee3d3698029bfd643080
Author: Geert Janssens <janssens-geert at>
Date:   Sat Nov 12 10:30:31 2016 +0100

    Bug 770364 - Sign of Value in Lots in Account window seems inconsistent
    Two parts to this bug:
    1. never reverse signs in the free splits list. Sign reversals don't
    make sense there.
    2. Sign reversal only makes sense for capital gains, not for business
    transactions. So only to the sign dance for non-business lots in the
    list of splits in the selected lot.

commit 5b832c7f9bec7e65077c139262e09070ada3e664
Author: Geert Janssens <janssens-geert at>
Date:   Sat Nov 12 09:22:09 2016 +0100

    Use G_MAXINT64 instead of 0 to indicate an invalid date

commit 96c22f54a38420c7c3d2e981711e685edc63675c
Author: Geert Janssens <janssens-geert at>
Date:   Fri Nov 11 21:32:30 2016 +0100

    Show empty business splits in lot viewer

commit 254b4fbc2fcdf697096fe7fd6aed6c97618472a0
Author: Geert Janssens <janssens-geert at>
Date:   Fri Nov 11 20:58:52 2016 +0100

    Check more splits while running check & repair on business accounts
    In addition, speed up the process a bit by already deleting empty splits as soon as they're encountered

commit a9c624bfad7d98cd95a39788b399914eea01ea7c
Author: Geert Janssens <janssens-geert at>
Date:   Fri Nov 11 14:03:13 2016 +0100

    Business check & repair - correct lot invoice state
    There have been situations where a lot refered to an invoice while
    it doesn't actually contain splits for that invoice (any more).
    The new code corrects this by removing the invoice reference from the lot.
    Also if the lot and its splits don't agree on the invoice they belong to
    set the lot invoice to whatever the splits indicate.

commit 396117eec9514f20916df858c9477857e6c92b9a
Author: Geert Janssens <janssens-geert at>
Date:   Wed Nov 9 18:44:21 2016 +0100

    Various small improvements to check & repair on business accounts
    - don't attempt to merge splits that belong to an invoice transaction. These splits are managed by the business code.
    - lot link cleanup can leave empty splits, remove these as well

commit d52f44a8c7055a1c91477abacfae5130de9cf569
Author: Geert Janssens <janssens-geert at>
Date:   Sun Nov 6 17:11:30 2016 +0100

    When juggling business splits while scrubbing set both value and amount
    With only value there were several warnings in the log file during scrubbing

commit 0bcd30301e8ae747bff8bea53a19a432a0ed9d5e
Author: Geert Janssens <janssens-geert at>
Date:   Sun Nov 6 17:10:30 2016 +0100

    Update progress bar while running Check & Repair
    Not complete - should still be added for check & repair invoked from a split register

commit 673888dee7c972d2ed8470ccc28c466162910a6d
Author: Geert Janssens <janssens-geert at>
Date:   Wed Nov 9 18:41:05 2016 +0100

    Remove lot from account while deleting the lot
    There was no way the account was informed about the lot being deleted.
    This was resulting into invalid lot lists in an account while scrubbing.
    Which would bomb at later stages like when re-running check & repair or
    opening the lot viewer. Also saving would report a number of critical messages
    about invalid objects, but these didn't result in a segfault.

Summary of changes:
 src/engine/Scrub.c                       |  55 ++++++++---
 src/engine/Scrub.h                       |   8 +-
 src/engine/Scrub2.c                      |  16 +++-
 src/engine/ScrubBusiness.c               | 151 +++++++++++++++++++++++++------
 src/engine/ScrubBusiness.h               |  17 ++--
 src/engine/gnc-lot.c                     |   3 +
 src/engine/gncInvoice.c                  |   6 +-
 src/engine/gncInvoiceP.h                 |   4 +
 src/engine/gncOwner.c                    |   2 +
 src/gnome/dialog-lot-viewer.c            |  27 +++---
 src/gnome/gnc-plugin-page-account-tree.c |  31 +++++--
 src/gnome/gnc-plugin-page-register.c     |  20 +++-
 src/gnome/window-reconcile.c             |   5 +-
 src/gnome/window-reconcile2.c            |   5 +-
 14 files changed, 268 insertions(+), 82 deletions(-)

More information about the gnucash-patches mailing list