gnucash master: Multiple changes pushed

Geert Janssens gjanssens at
Thu Nov 24 12:07:18 EST 2016

Updated	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit e4bb9b70f80be576c3304e5ceca42bc9d01f7024
Merge: 427d467 bc33d56
Author: Geert Janssens <janssens-geert at>
Date:   Thu Nov 24 14:19:50 2016 +0100

    Merge branch 'maint'

commit bc33d564a8f6533936521d3276ce9c300b56afdd
Author: Robert Fewell <14uBobIT at>
Date:   Wed Nov 16 19:23:58 2016 +0000

    Changed the default value for date format
    Set the default value to the new 'No Fancy Date Format'.

commit a56f031d4591b610e468fcc305ac091ed410198e
Author: Robert Fewell <14uBobIT at>
Date:   Wed Nov 16 19:22:21 2016 +0000

    Fix check printing custom preference value
    The scheme option is 'date-format-user' so corrected here.

commit a67b4922c250004a16457dd58d7f21003cb7d9b4
Author: Robert Fewell <14uBobIT at>
Date:   Wed Nov 16 19:20:15 2016 +0000

    Correct the default options if default invalid
    The default value should be a list and have set the default to the new
    "No Fancy Date Format" option.

commit 5ce8878764a47f0ff9f98f5bc7cc50858229fd72
Author: Robert Fewell <14uBobIT at>
Date:   Wed Nov 16 19:13:50 2016 +0000

    Add an unset option to date-format
    Added an option of "No Fancy Date Format" to date-format so it can be
    the default. In this position, the format returned is that of what ever
    the preference date is set to.

commit d56c3d3ac801251c60a8371e873d773ac3dee81a
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 15:59:44 2016 +0000

    Added a default currency to the currency option
    This was causing an error when the dialog options was raised.

commit 12562bcc0ccc5ae3f05f65fc74e14291d73ecec3
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 15:24:38 2016 +0000

    Add plot size option for future compatibility
    This is really just a copy of the number-range-option with some tests
    for the saved value being a pair which is used in later versions. If the
    pair is a pixel setting, then that value will be used, otherwise the
    default value is used. Should any report get saved, the saved values
    will be over written in the old format.

commit da0b3b51313080ebf9d61f3a66f88a342788d790
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 12:12:30 2016 +0000

    Fix warning from glib when saving reports.
    Glib complains about an already initialised pointer, there is no need
    to initialise when used with gtk_tree_model_get_value.

commit 74091fbcfab4e5d731bb6283c07c38ccc58326e1
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 12:05:13 2016 +0000

    Change report resizing when not in view
    When you have reports open but they are not selected, resizing the
    window does not always resize the hidden report views properly. Use
    the expose call back so the reports are reloaded on expose event.

commit 372b3cc8226704ed747de693bdfde0ddc8e55a1b
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 12:03:55 2016 +0000

    Forgot to add the png file to previous commit

commit 371222cb6af4929a9bdcd875db13f4cfcb608a27
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:29:37 2016 +0000

    Add an image for the report tab
    There was an entry in plugin-page-report about a missing image for the
    report tab so have created one and added it.

commit 49014f4714adb31d860b4ef18aab08989585cc55
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:27:51 2016 +0000

    Change the reload to include using web_view_reload
    In the resize call backs, use the webkit view reload function instead of
    recreating the report.

commit 891dcbc339567eb857491f4593548d72a9a265ff
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:18:44 2016 +0000

    Track visibility of the view scroll bars
    When the scroll bars show they can affect the chart so force a reload
    when they show.

commit 51277bcd81c806a327c17265bd46c2dc7d4464e4
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:16:36 2016 +0000

    Add progress bar updates for reload / Update
    Added progress bar updates for refresh/reload button press and also for
    when the options change. Created a new function to set progress bar
    height from previous commit to be used for above changes.

commit 12994ca6e77cba58cf9de5a2f6b2b3f4323e77b3
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:15:23 2016 +0000

    Add call back to track page size changes
    Add call back to track size-allocate events for the webkit view. Also
    commented out expose event as that may not be required.

commit 62e449f37b227ca0c954f39249c5d22cbc2a42d4
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:09:43 2016 +0000

    Stop the progress bar changing height
    When the report is run and the progress bar is updated, the height
    changes and then changes back forcing the webkit view to change height
    and ultimately use the wrong value.

commit 1b2f89e1948b9bff9406da45b639a2ecaa14647e
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 11:07:42 2016 +0000

    Add idle function to load report
    The reason for webkit not using the full report area is that this area
    has not been realized when the report is created and so webkit does not
    know the correct size. By using the idle function, the page is created
    and realized before loading the report with the added advantage the
    progress bar updates on the blank report page.

commit d7648a2ba72354348b03a3bc6dfcc97fa1fdec52
Author: Robert Fewell <14uBobIT at>
Date:   Tue Nov 15 10:44:14 2016 +0000

    Remove macros/as-scrub-include.m4 from makefile
    This has already been removed in previous commit.

commit 1339c1161fcd8bd76b0d8a57ea5a3946cddfb9f6
Author: Geert Janssens <janssens-geert at>
Date:   Sun Nov 13 17:26:43 2016 +0100

    Fix make check after commit 673888dee7c
    - Update the lot list of the lot's account only when the account itself is not being destroyed
    - Fix the test cases to accept the new (improved) lot destruction handling

commit ecb43e7d72941c32bc7bee3d3698029bfd643080
Author: Geert Janssens <janssens-geert at>
Date:   Sat Nov 12 10:30:31 2016 +0100

    Bug 770364 - Sign of Value in Lots in Account window seems inconsistent
    Two parts to this bug:
    1. never reverse signs in the free splits list. Sign reversals don't
    make sense there.
    2. Sign reversal only makes sense for capital gains, not for business
    transactions. So only to the sign dance for non-business lots in the
    list of splits in the selected lot.

commit 5b832c7f9bec7e65077c139262e09070ada3e664
Author: Geert Janssens <janssens-geert at>
Date:   Sat Nov 12 09:22:09 2016 +0100

    Use G_MAXINT64 instead of 0 to indicate an invalid date

commit 96c22f54a38420c7c3d2e981711e685edc63675c
Author: Geert Janssens <janssens-geert at>
Date:   Fri Nov 11 21:32:30 2016 +0100

    Show empty business splits in lot viewer

commit 254b4fbc2fcdf697096fe7fd6aed6c97618472a0
Author: Geert Janssens <janssens-geert at>
Date:   Fri Nov 11 20:58:52 2016 +0100

    Check more splits while running check & repair on business accounts
    In addition, speed up the process a bit by already deleting empty splits as soon as they're encountered

commit a9c624bfad7d98cd95a39788b399914eea01ea7c
Author: Geert Janssens <janssens-geert at>
Date:   Fri Nov 11 14:03:13 2016 +0100

    Business check & repair - correct lot invoice state
    There have been situations where a lot refered to an invoice while
    it doesn't actually contain splits for that invoice (any more).
    The new code corrects this by removing the invoice reference from the lot.
    Also if the lot and its splits don't agree on the invoice they belong to
    set the lot invoice to whatever the splits indicate.

commit 396117eec9514f20916df858c9477857e6c92b9a
Author: Geert Janssens <janssens-geert at>
Date:   Wed Nov 9 18:44:21 2016 +0100

    Various small improvements to check & repair on business accounts
    - don't attempt to merge splits that belong to an invoice transaction. These splits are managed by the business code.
    - lot link cleanup can leave empty splits, remove these as well

commit d52f44a8c7055a1c91477abacfae5130de9cf569
Author: Geert Janssens <janssens-geert at>
Date:   Sun Nov 6 17:11:30 2016 +0100

    When juggling business splits while scrubbing set both value and amount
    With only value there were several warnings in the log file during scrubbing

commit 0bcd30301e8ae747bff8bea53a19a432a0ed9d5e
Author: Geert Janssens <janssens-geert at>
Date:   Sun Nov 6 17:10:30 2016 +0100

    Update progress bar while running Check & Repair
    Not complete - should still be added for check & repair invoked from a split register

commit 673888dee7c972d2ed8470ccc28c466162910a6d
Author: Geert Janssens <janssens-geert at>
Date:   Wed Nov 9 18:41:05 2016 +0100

    Remove lot from account while deleting the lot
    There was no way the account was informed about the lot being deleted.
    This was resulting into invalid lot lists in an account while scrubbing.
    Which would bomb at later stages like when re-running check & repair or
    opening the lot viewer. Also saving would report a number of critical messages
    about invalid objects, but these didn't result in a segfault.

commit 32c4d1458870bdbcdbed1b47f23c2957af1f8f3d
Author: John Ralls <jralls at>
Date:   Thu Nov 10 13:56:09 2016 -0800

    Ensure that the Namespace combo box is initialized to a valid iter.
    Thanks to David T. for noticing that it wasn't.

commit 5fcdfba69c9a630767d56db45a52c0087ba2c594
Author: John Ralls <jralls at>
Date:   Mon Oct 24 11:21:12 2016 +1100

    Bug 769124 - Australian (GMT-10) OFX transactions imported have previous
    day's date. Previous efforts didn't work on Windows and shouldn't have
    elsewhere because gnc_localtime and gnc_mktime are inverse functions;
    in particular gnc_mktime doesn't adjust the time based on the value
    of tm_isdst, though some implementations of STDC mktime do.
    Rather than being too clever about trying to find the DST offset this
    implementation just uses 1 hour.

commit 6695ef9585c638650b97ce1dd9122095b9485008
Author: John Ralls <jralls at>
Date:   Thu Oct 20 10:40:18 2016 -0700

    Bug 769124 - Australian (GMT-10) OFX transactions imported have previous days date.
    Fix on Windows, where the test failed to build.

commit c68452a497ce707c662df2efc5bef9ef9123a6ce
Author: Rob.Gowin <robgowin at>
Date:   Fri Oct 14 14:17:04 2016 -0500

    Remove configuration of HAVE_PUTENV.
    The Python includes files for Windows define HAVE_PUTENV to be
    empty. GnuCash under MINGW (only) defines it to be 1. This causes
    redefinition errors when building the Python bindings on Windows.
    HAVE_PUTENV is not used in the GnuCash code base, so the best
    solution seems to be to just get rid of it.

Summary of changes:
 CMakeLists.txt                                     |  15 +-                                       |   5 +-
 src/CMakeLists.txt                                 |   4 -
 src/app-utils/app-utils.scm                        |   1 +
 src/app-utils/options.scm                          |  44 +++++-
 src/                              |   3 -
 src/engine/Scrub.c                                 |  55 +++++--
 src/engine/Scrub.h                                 |   8 +-
 src/engine/Scrub2.c                                |  16 +-
 src/engine/ScrubBusiness.c                         | 151 ++++++++++++++----
 src/engine/ScrubBusiness.h                         |  17 +-
 src/engine/gnc-lot.c                               |   3 +
 src/engine/gncInvoice.c                            |   6 +-
 src/engine/gncInvoiceP.h                           |   4 +
 src/engine/gncOwner.c                              |   2 +
 src/engine/test/utest-Account.cpp                  |  12 +-
 src/gnome-utils/dialog-commodity.c                 |   8 +-
 src/gnome-utils/dialog-options.c                   | 101 ++++++++++++
 src/gnome-utils/gnc-date-format.c                  |   2 +-
 src/gnome-utils/gnc-icons.c                        |   1 +
 src/gnome-utils/gnc-icons.h                        |   1 +
 src/gnome-utils/gnc-window.c                       |   2 +-
 src/gnome-utils/gnc-window.h                       |   1 +
 src/gnome-utils/gtkbuilder/   |   7 +-
 src/gnome/dialog-lot-viewer.c                      |  27 ++--
 src/gnome/dialog-print-check.c                     |   2 +-
 src/gnome/gnc-plugin-page-account-tree.c           |  31 ++--
 src/gnome/gnc-plugin-page-register.c               |  20 ++- |   2 +-
 src/gnome/window-reconcile.c                       |   5 +-
 src/gnome/window-reconcile2.c                      |   5 +-
 src/html/gnc-html-webkit.c                         |  14 +-
 src/html/gnc-html.c                                |  21 ++-
 src/html/gnc-html.h                                |   5 +-
 src/import-export/ofx/gnc-ofx-import.c             |   9 +-
 src/libqof/qof/gnc-date.cpp                        |   8 +
 src/libqof/qof/gnc-date.h                          |   3 +-
 src/libqof/qof/test/test-gnc-date.c                |   3 +
 src/pixmaps/                            |   2 +
 src/pixmaps/gnc-account-report-16.png              | Bin 0 -> 417 bytes
 src/pixmaps/gnc-account-report.png                 | Bin 0 -> 359 bytes
 src/report/business-reports/taxinvoice.scm         |   5 +-
 src/report/report-gnome/dialog-custom-report.c     |   2 -
 src/report/report-gnome/gnc-plugin-page-report.c   | 174 +++++++++++++++------
 src/report/report-system/options-utilities.scm     |   4 +-
 45 files changed, 634 insertions(+), 177 deletions(-)
 create mode 100644 src/pixmaps/gnc-account-report-16.png
 create mode 100644 src/pixmaps/gnc-account-report.png

More information about the gnucash-patches mailing list