gnucash master: Multiple changes pushed

Geert Janssens gjanssens at
Fri Apr 28 14:50:25 EDT 2017

Updated	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	 via (commit)
	from (commit)

commit 1a3595cbeb6b6cb3b5771d0e303c0139949169aa
Author: Geert Janssens <geert at>
Date:   Fri Apr 28 16:42:54 2017 +0200

    Convert gnc_dmy2timespec{,_end,_neutral} to use the equivalent GncDateTime constructor
    This required a couple of tweaks to the tests because:
    - the invalid date returned for impossible conversions is different between the old implementation and the cpp edition
    - unhandled glib warnings caused the tests to abort

commit 7a037932ae3a5a6aa3304344aa5138715168150d
Author: Geert Janssens <geert at>
Date:   Fri Apr 28 16:38:30 2017 +0200

    Align day end time as used in the GncDateTime constructor and gnc_dmy2timespec_end
    The former was using 23:59:00 while existing code was using 23:59:59. To avoid
    disruptions, stick with the latter in our cpp code as well.

commit 586b89c6ca7f647b54da4e26f97f060c80b084ec
Author: Geert Janssens <geert at>
Date:   Fri Apr 28 14:17:33 2017 +0200

    Fix John's remarks

commit 610f6309a378b03d18e33315f29efaf3dd966ddd
Author: Geert Janssens <geert at>
Date:   Fri Apr 28 18:39:31 2017 +0200

    Fix double free abort in gtest-gnc-datetime.cpp
    This double free happened after the introduction of a class variable (static member variable
    to GndDate and the test compiling in gnc-datetime.cpp *and* at the same time linking to
    gnc-qof. This apparently threw off internal memory management. Removing either of linking to
    gnc-qof or compiling in the source file solved it.
    Credits go to John Ralls for debugging this.

commit 209f97158974d9120e311de5d9bb70a5a10efc49
Author: Geert Janssens <geert at>
Date:   Fri Apr 21 16:58:20 2017 +0200

    Add constructor to create GncDate from string and predefined date format
    Primary use case is for parsing dates from external sources (importers)

commit 9b30bb2b629edbaaf7fa12854f3a7ba3ded84d36
Author: Geert Janssens <geert at>
Date:   Sat Apr 22 17:00:34 2017 +0200

    Various small fixups in csv importer
    - Use descriptive names instead of numbers in std::get<>
    - Remove unused parameters
    - Fix some doxigen comments

commit b7bcd792f6e4ff050c26c5ceeab3606b4581eebb
Author: Geert Janssens <geert at>
Date:   Fri Apr 28 18:25:34 2017 +0200

    Align cmake rational/numeric test invocation with Makefile based one
    This invocation avoids linking in gnc-qof and instead will
    directly pull in all sources required.

commit b5530bd41fd2d2cc4b738fdfcdd139f17bae49ce
Author: Geert Janssens <geert at>
Date:   Wed Apr 26 10:59:46 2017 +0200

    Fix autotools based build
    For some reason gnc-vcs-info.h isn't found properly any more although
    the relevant parts of the Makefiles haven't changed compared to the
    maint branch. Perhaps a compiler option has changed ? Anyway simply
    adding its path explicitly does fix it.

Summary of changes:
 src/bin/                                |   1 +
 src/engine/test/test-date.cpp                      |   6 +-
 src/engine/test/utest-gnc-pricedb.c                |   7 +
 src/gnome-utils/                        |   1 +
 .../csv-imp/assistant-csv-trans-import.cpp         |  16 +--
 .../csv-imp/gnc-csv-trans-settings.cpp             |   2 +-
 .../csv-imp/gnc-csv-trans-settings.hpp             |   7 +-
 src/import-export/csv-imp/gnc-tx-import.cpp        |  56 ++++----
 src/import-export/csv-imp/gnc-tx-import.hpp        |  16 ++-
 src/libqof/qof/gnc-date.cpp                        |  76 +++--------
 src/libqof/qof/gnc-datetime.cpp                    | 122 ++++++++++++++++-
 src/libqof/qof/gnc-datetime.hpp                    |  79 ++++++++++-
 src/libqof/qof/test/CMakeLists.txt                 |  34 ++++-
 src/libqof/qof/test/                    |   7 +-
 src/libqof/qof/test/gtest-gnc-datetime.cpp         | 148 ++++++++++++++++++++-
 src/libqof/qof/test/test-gnc-date.c                |  45 +++++--
 16 files changed, 492 insertions(+), 131 deletions(-)

More information about the gnucash-patches mailing list