gnucash master: Multiple changes pushed

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/d9303023 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/8c8af544 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9d57447f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6bba5512 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4949499b (commit)
	 via  https://github.com/Gnucash/gnucash/commit/80e64a12 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/3889606d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/bc50f3da (commit)
	 via  https://github.com/Gnucash/gnucash/commit/97598c43 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/03ff5d37 (commit)
	from  https://github.com/Gnucash/gnucash/commit/be260a43 (commit)



commit d9303023e0766bf2b033240c3a63c354f141bf08
Author: Christoph Rohland <christoph at rohland.net>
Date:   Sat Mar 11 11:56:59 2017 +0100

    Fix logic error for discounts
    
    Got it all wrong before. Don’t use to complex expressions!

commit 8c8af54420909941a85b1cce7ee9e9024bd59a9e
Author: Christoph Rohland <christoph at rohland.net>
Date:   Fri Mar 10 19:31:09 2017 +0100

    Fix taxinvoice for bill entries with taxes
    
    taxinvoice was throwing an exception when there were taxes on bill entries.
    It also did scan the invoice parts to determine if there were taxes and discounts.

commit 9d57447fe1468288b48382c1bcf265a0d92b13bd
Author: Christoph Rohland <christoph at rohland.net>
Date:   Wed Mar 8 15:08:54 2017 +0100

    Let taxinvoice optionally show the net instead of the given price
    
    This is needed if there is a mix of entries with tax included and
    excluded

commit 6bba55128f31a9ff7419fe30ca87d015ac5371e7
Merge: be260a4 4949499
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Mar 11 15:57:44 2017 +0100

    Merge branch 'maint'

commit 4949499bd44581419298a4b220fdbbe2c639a257
Author: Christoph Rohland <christoph at rohland.net>
Date:   Thu Mar 9 15:01:11 2017 +0100

    Charge back net value of bill entries in invoices
    
    When charging entries from bills we need to exclude taxes since the tax
    rate of the invoice might be different than that of the bill.
    
    This fixes Bug 776380 - Gross value of bills charged back instead of
    net value (https://bugzilla.gnome.org/show_bug.cgi?id=776380)

commit 80e64a129607f0bd4f02480ee10e85201420c6a8
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 10 14:23:20 2017 -0800

    Fix failed unit test from previous commit.

commit 3889606dd6779564341247ec796a905b54d36426
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 10 13:21:02 2017 -0800

    Bug 779217 - Transactions rounded to 5 decimal places when opening file.
    
    xaccSplitSetValue and xaccSplitSetAmount round to the denominator found by
    get_currency_denom and get_commodity_denom. The problem was that if the
    commodity was unfindable because either the split’s parent or account hadn’t
    been set (as is the case during loading, because the parent isn’t yet complete)
    the returned denominator would be 100000, smaller than the max supported.
    That would cause the value/amount to be prematurely rounded.

commit bc50f3da005d707067a83d74852ad1bcc69f857b
Author: John Ralls <jralls at ceridwen.us>
Date:   Fri Mar 10 10:54:22 2017 -0800

    Bug 777949 - Accounts implicitly created in ledger attempt creation twice
    
    Guard against recursively calling the account doesn’t exist query or creation
    dialog if one is already in the account creation dialog.
    
    The underlying problem is that creating the dialog forces a UI update that
    in turn sets the cell value and checks for the existence of the account.
    In basic view the cell being displayed (“transfer”) isn’t the one being
    changed (“account”) so the account check isn’t invoked, but in
    multi-split view the “account” cell *is* displayed so the check is invoked
    again.

commit 97598c430693239d6aeab9dc4ff6f49e789cebff
Author: John Ralls <jralls at ceridwen.us>
Date:   Thu Mar 9 11:38:42 2017 -0800

    Bug 776564 - Creating a scheduled transaction from an existing...
    
    transaction does not include the notes field.
    
    In fact, notes support was entirely missing from scheduled transactions.

commit 03ff5d3778c9d3148f08b72dca0b984a36ec74df
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Sat Mar 4 12:25:56 2017 +0100

    Allow only date entry for opening balances on new accounts
    
    This anomaly was spotted by Christopher Lam



Summary of changes:
 src/engine/SX-ttinfo.c                            | 25 +++++++++++++++-
 src/engine/SX-ttinfo.h                            |  3 +-
 src/engine/SchedXaction.c                         |  1 +
 src/engine/Split.c                                |  4 +--
 src/engine/gncInvoice.c                           |  6 +++-
 src/engine/test/utest-Split.cpp                   |  6 ++--
 src/gnome-utils/dialog-account.c                  |  2 +-
 src/gnome/dialog-sx-from-trans.c                  |  1 +
 src/register/ledger-core/split-register.c         |  6 ++--
 src/report/business-reports/taxinvoice.eguile.scm | 36 ++++++++++++-----------
 src/report/business-reports/taxinvoice.scm        |  3 ++
 11 files changed, 65 insertions(+), 28 deletions(-)